[linux-dvb] Re: play_iframe not working

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Johannes Stezenbach wrote:
> 
> Klaus Schmidinger wrote:
> >
> > Is it possible that the driver was able to handle "my" I-frames in the old
> > version, but the new version makes some assumptions on the format that my
> > data doesn't fulfill?
> 
> I don't know. I don't even know if my I-frames are in correct format
> or if yours aren't. All I know is that the driver does what I expect it
> to do. If your patch doesn't break anything, I have no objections
> to Ralph applying it.
> (If you could even prove that your I-frames are in
> correct format, and your patch does in fact fix a driver bug,
> it would be even better. But maybe wait what Ralph has to say
> about it...)
> 
> Regards,
> Johannes

I believe I found what's wrong eith the new 'play_iframe()'.
The old version sent the iframe_header data only once, while the
new version does this inside the for-loop. If I move that line
outside the for-loop, it works fine for me.

Here's the patch agains the latest CVS driver:

--- dvb.c.001   Sat Jul 21 00:08:18 2001
+++ dvb.c       Sun Jul 22 17:59:36 2001
@@ -4580,8 +4580,8 @@
                 n=1;
         else
                 n=MIN_IFRAME/len+1;
+        instant_repack(iframe_header, 9, &dvb->ipack[1]);
         for (i=0; i<n; i++) {
-               instant_repack(iframe_header, 9, &dvb->ipack[1]);
                instant_repack(buf, len, &dvb->ipack[1]);
                //dvb_play(dvb, iframe_header, 9, 0, 1);
                //dvb_play(dvb, buf, len, 0, 1);


Klaus
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________


-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.