[linux-dvb] AW: Re: why emergency exit on channel switching problems ?

["Rienecker, Fa. Evenio, ITS P, M" <C.Rienecker@deutschepost.de>]

> -----Ursprüngliche Nachricht-----
> Von: Carsten Koch [mailto:Carsten.Koch@icem.de]
> Gesendet: Dienstag, 4. September 2001 14:01
> An: linux-dvb@linuxtv.org
> Betreff: [linux-dvb] Re: why emergency exit on channel switching
> problems ?

> ....

> 1.  Replace all hardcoded numbers (except, in some cases, 0 and 1)
>     in the source text with symbolic names.
> 
> 2.  Create a glossary of the most common abbreviations (like i2c)
>     and spell out all words not listed in the glossary.
> 
> 3.  Make sure all externally callable functions carefully check
>     all error conditions. Return the appropriate error code 
> on possible 
>     error conditions and raise an assertion on impossible 
> error conditions.
> 
> Believe me, I am not trying to negatively criticize your great work.
> Honestly! I am trying to help.
> I follow the same practise in my own code and I enforce it in code
> that I have to review at work. It really helps a lot.

Yes, yes, yes.
The above code would not go through with me either.
It is not maintainable (except maybe for a few brilliant guys who write such
code) and extremly error-prone. And, worst of all, almost impossible to
debug.

CR.

> 
> 
> Carsten.
> 
> 
> -- 
> Info:
> To unsubscribe send a mail to listar@linuxtv.org with 
> "unsubscribe linux-dvb" as subject.
> 


--
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.