[linux-dvb] Re: Announcement: new saa7146 driver core for theav7110 dvb driver

[Holger Waechtler <holger@convergence.de>]

Hi Michael,

Matthias Behr wrote:
> Hi Michael,
> 
> 
>>By looking at code, this should not happen. But I'm not sure, perhaps I
>>missed something. Follow the function calls by yourself.
>>
>>saa7146_init_module() calls pci_module_init(), which *should* call
>>saa7146_init_one() (and therefore request_irq()) way before any
>>extension (and the av7110) can handle anything related to the saa7146...
> 
> 
> I just feared that there might be an interrupt pending on the saa7146 and
> inside configure_saa7146 (called from saa7146_init_one()) request_irq is
> called before the saa is reset and ints disabled. So I fear that between the
> call "request_irq" and "saa7146_write( saa->mem, MC1, 0xbfff0000)" an
> interrupt might happen.

to be safe you should call request_irq() after and only if all 
initialisations and buffer allocations were successfully...

Holger



-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.