[linux-dvb] Re: [vdr] Re: ERROR (dvbdevice.c,533)

[Andreas Kool <akool@akool.de>]

On Sun, May 04, 2003 at 01:08:53PM +0200, Oliver Endriss wrote:

[...]
> > > I think we need a reliable way to identify cable cards.
> >
> > Correct. Maybe the MSP34xx chip could be another criteria for cable
> > cards?
>
> It's easy to auto-detect the MSP34xx chip but this will only help for
> cable cards *with* analog module installed. Without analog module we do
> not know whether we have a DVB-S or a DVB-C.
>
> The current code works like this:
> ...
> av7110->adac_type = DVB_ADAC_TI;
> ...
> if (crystal chip present)
> 	av7110->adac_type = DVB_ADAC_CRYSTAL;
> else if (av7110->saa->device->subsystem_vendor == 0x110a) {
> 	if (MSP34xx chip present)
> 		av7110->adac_type = DVB_ADAC_MSP;
> 	else
> 		av7110->adac_type = DVB_ADAC_NONE;
> }
>
>
> The problem is that we must *not* set DVB_ADAC_NONE for DVB-S cards.
> Maybe we should change the code as follows:
> ...
> av7110->adac_type = DVB_ADAC_TI;
> ...
> if (crystal chip present)
> 	av7110->adac_type = DVB_ADAC_CRYSTAL;
> else if (MSP34xx chip present)
> 	av7110->adac_type = DVB_ADAC_MSP;
> else {
> 	if (av7110->saa->device->subsystem_vendor == 0x110a)
> 		av7110->adac_type = DVB_ADAC_NONE;
> }
>
> This should fix the problem for all cable cards *with* analog module.
> Cable cards without analog module and id != 0x110a cannot be detected
> because I don't know how they could be distinguished from DVB-S cards.
> It is important not to set DVB_ADAC_NONE for DVB-S!
>
> What do you think?

Full ACK, but one extension:

The module parameter "adac=" should have priority over the autodetect
code.

> Oliver

Ciao,
Andreas
--
Andreas Kool (akool@akool.de * akool@isdn4linux.de * http://www.akool.de)
PGP: 3FBF2411 Fingerprint: B5 35 34 74 25 60 2A 7A  89 06 92 C4 08 BA A5 BD
(To get my PGP key, send me a mail with subject "send pgp key")
		X <-- Nail here for a new Monitor
Transmission of this message via the Microsoft Network is prohibited


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.