Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: [PATCH] ves1820 inversion



Andreas Oberritter wrote:
hi,

i would like to commit this patch at least to dvb-kernel. the software
auto inversion hack does not work. so i removed it.
Please revert it, reason below.

imho inversion
handling should be left to the application. this way it works fine on a
nokia dbox2-c. any complaints?
That's only possible if you know the real I/Q pin assignment. Unfortunally some Hauppauge DVB-C cards have swapped I/Q pins but the Siemens cards not. (don't know who of them is correct, but if I get any of the responsible engineers into my hands I'll kill him - )


another issue is, that since i and q are swapped on the pci cable cards,
inversion on/off are swapped, too. how about adding a flag for that and
only on some of the cards.

do something like if ((inv != INVERSION_AUTO) && (flag)) inv = !inv?
hmm, I don't know what exactly do you mean, but it should be definitely possible to get the inversion autoprobing working, and at the time I coded this it actually worked. Maybe we have to increase some of the delays or there became something broken in the REG0 initialisation, many people changed a lot in this code last time.

The stv0299 driver is using a similiar approach and everything is working fine there.

Maybe we can guess the real I/Q pin assignment from the adapter name string derived from the vendor ID, but I'm not perfectly sure about this and I don't have all the existing cards here to find out who is using which configuration.

Holger



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.



Home | Main Index | Thread Index