On Tue, Dec 02, 2003 at 12:12:02PM +0100, Niklas Peinecke wrote:
I tried my best to take all your suggestions into account and rewrote
the filters for the skystar2 cards. Especially (based on the valueable
info given by Augusto) there is now a different handling for FC IIb and
FC III based cards, the additional 32 PID filters should work. Also I
tried my best to handle the 0x2000/open_whole_bandwidth issue in a
transparent way.
...
Hi Niklas,
I'm sending you back your patch (it's against yesterdays CVS) ;-)
- I fixed some things to get it to compile ;-)
- I added a two-level debug: 2 is the old version, 1 is less noisy.
- I did some cosmetic changes (see /usr/src/linux/Documentation/CodingStyle).
- I did _not_ change anything of the functionality of your code.
Your patch is working fine here, but I can only check the 6 hw pids:
I also have a FlexCopII :-(
Your patch is very similiar to mine; differences: e.g. I removed the
default 0x1f mask, and I added a counter how often open_whole_bandwidth()
was called and only close it, when the counter is 0 again.
I'll come back with some proposals when I had more time to have a look at
your code:
One problem might be that we might have to track how often an identical
hw_pid was requested before we can savely remove it from the list, and we
should add a modul parameter like 'use_hardware_filters'.
Do we really need pid_counter? I think the upper layer will do that for
us.
More later ...
do you think the patch is ready for CVS? Don't have a skystar2 here, so
I can't test it myself...