Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: [PATCH] Losless Section Demux version 1.4



Hi Emard,

On Sun, 2003-11-30 at 13:57, Emard wrote:
> Should someone look for missing data, he should look for the
> bugs elsewhere, and definitely not in the LSD 1.4 because it 
> receives sections 100% complete even in bounday conditions.

Today I merged the latest dvb-kernel cvs into our cvs tree, which
contains a driver for the AViA GTX and eNX. Using your new section demux
filtering does not work anymore, because you broke the accelerated
memcopy. This memcopy callback also checks crc32 in our driver (which is
the reason why this and the crc32 callback were introduced in
dvb-kernel). Your implementation does a) not set crc_val to ~0 for new
sections before calling memcopy and b) does not restrict memcopy to the
size of the copied section. Unfortunately this is not documented, so it
is not your fault that you didn't notice. I tried to fix the code but
didn't succeed. What is the exact difference to the old section demux
and why shouldn't we fix the old one instead if it is broken?

Can you please fix this remaining issue?

Regards,
Andreas

Attachment: signature.asc
Description: This is a digitally signed message part


Home | Main Index | Thread Index