[linux-dvb] Re: badness in interruptible_sleep_on_timeout

[Johannes Stezenbach <js@convergence.de>]

Hi,

On Thu, Jan 29, 2004 at 05:06:19PM +0100, Michael Hunold wrote:
> Hello Andrew,
> 
> >Im posting this to the list as it may be of some intrest since it seems to 
> >be dvb related, the kernel is 2.6.2-rc2-mm1 and when using the tda1004x 
> >driver and budgetci with a pci nova-t i get:
> >
> >Badness in interruptible_sleep_on_timeout at kernel/sched.c:2254
> >Call Trace:
> > [<c01207af>] interruptible_sleep_on_timeout+0x10f/0x120
> > [<c0120240>] default_wake_function+0x0/0x20
> > [<f1993138>] dvb_frontend_internal_ioctl+0x38/0x90 [dvb_core]
> > [<f1993af9>] dvb_frontend_thread+0xb9/0x2b0 [dvb_core]
> > [<f1993a40>] dvb_frontend_thread+0x0/0x2b0 [dvb_core]
> > [<c010b289>] kernel_thread_helper+0x5/0xc
> >
> >Although it dosnt seem to affect the operation of the card.
> 
> Thanks for the report. The various sleep_on() function often have race 
> conditions, so the usage should be avoided. It's said that wait_event() 
> and friends can be used in a more safely manner and should be used instead.
> 
> AFAIK some checks have been introduced that print a warning once a 
> driver uses one of the old functions.
> 
> So, nothing serious, but it should be changed.

Kümmerst Du Dich darum? Ich hätte das gerne noch vor dem
1.1.0 Release draußen.

Johannes


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.