[linux-dvb] Re: tda1004x and sys_close

[Holger Waechtler <holger@convergence.de>]

Bernd Bartmann wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Johannes Stezenbach schrieb:
> | Bernd Bartmann wrote:
> |
> |>Johannes Stezenbach schrieb:
> |>| The home-grown firmware loader code in the various frontend drivers
> |>| is problematic and should be replaced by request_firmware(). This
> |>| has been discussed briefly on the list, but no one implemented it yet.
> |>| (The #define __KERNEL_SYSCALLS__ hack caused a complaint
> |>| on lkml recently.)
> |>
> |>So is there a way to circumvent the problem in the meantime? What's
> |>missing? Just an include?
> |
> |
> | Ask Redhat.
>
> They say exactly what you already stated yourself:
>
> - ------- Additional Comments From arjanv@redhat.com  2004-02-16 15:45
> they have very evil code there; it's not allowed to read files from
> kernel space like that, they should use request_firmware interface
>
> So it looks like we won't get a usable tda1004x in FC2 until
> request_firmware is used.
>
> Best regards.
>
> - --
Use a clean and unpatched kernel from http://www.kernel.org/ instead of 
the version of your distributor.

Or port the code to the request_firmware() stuff and post a patch. Keep 
in mind that this makes the code unportable to older kernels then - they 
might be required in case you are bound to a special kernel version 
because you need a realtime kernel or are working on an embedded 
platform where the latest'n'greatest kernel is not yet available.

Holger



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.