[linux-dvb] Re: [PATCH] dvb-ttpci+budgetpatch integrated v22

[emard@softhome.net]

On Tue, Jan 04, 2005 at 03:39:02PM +0100, Johannes Stezenbach wrote:
> Hi,
> 
> emard@softhome.net wrote:
> > Naming of dvbnet devices is fixed, they are
> > now called dvb000 for net0 and dvb010 for net1
> > ("_" in the middle of dvb0_0 is used to indicate
> > id of net* interface)
> 
> Please don't do that. There is not need to, is there?
> I guess that would break various scripts.

HM! Something is a need, beacuse it got me oops when I first
want to register dvb0_0 from net0 and then again I
tried to register dvb0_0 from net1.

A solution for dvbX_Y would be to code adapter+net number 
into the first digit, so adapter0-3/net0 range would be 
dvb0-3_X as before, and adapter0-3/net1 would create dvb4-7 etc.

Theoretically, we would have to allow for HEX digits, since a 
range of 4 adpaters x 4 nets gives 16, so some exotic 
configurations could give something like dvbA_0 as well.

Is that acceptable?

> > demux1 exists but receives no data.
> 
> IMHO that's not acceptable. If you can't probe for the presence
> of the hardware support for demux1 you need to have a
> module parameter to enable it.

I *can* probe but prior to reliable detection, it seems that
I have to reset saa7146 :(. Better to go for module parameter.

> The naming convention must not be change for compatibility
> reasons. Maybe dvb_net -l can be changed to display netX number?

Hmmm lemme thing, dvbnet -n0 -l lists nets from net0,
dvbnet -n1 -l lists them from net1, so just dvbnet -l
should list all devices for -n*. 
Displaying net name there is not problem, it could 
support HEX naming convention

> 
> Some coding style issues:
> - don't mix tabs and spaces (you do it in a few places)

Aiieee, I should set editor to convert all tabs to spaces etc

> - don't add #if 0'ed code without a comment why it needs to be there
> - please use the usual block comment style not you special one

That's right, another cleanup version will follow

Emard