[vdr] Re: ANNOUNCE: console plugin vdr-console-0.1.0

["Jan Rieger" <jan@ricomp.de>]

> -----Original Message-----
> From: vdr-bounce@linuxtv.org [mailto:vdr-bounce@linuxtv.org] 
> On Behalf Of Stefan Reinauer
> Sent: Tuesday, November 19, 2002 3:08 PM
> To: vdr@linuxtv.org
> Subject: [vdr] Re: ANNOUNCE: console plugin vdr-console-0.1.0
> 
> 
> * Jan Rieger <jan@ricomp.de> [021119 11:58]:
> > because of the actual discussion about VDR as a terminal, i 
> would like 
> > to announce my plugin "console" for the developer version of VDR.
> [..] 
> > The plugin is developed under VDR version 1.1.15 but it 
> schould also 
> > function with older and newer versions of the developer version of 
> > VDR.
> > 
> > You can download the actual version from 
> > http://ricomp.de/vdr/vdr-console-0.1.0.tgz .
> 
> Cool work!
> 2 minor issues:
> 
> * why do you set REMOTE_KBD in case REMOTE is not set, even though it
>   does not work? I suggest setting this to lirc to make the module
>   compile in that case. (Or is this somewhat evil? I have the vdr
>   includes in /usr/include/vdr/ and compile all plugins outside of the
>   vdr tree, in which case this fails

I set it because this is the same behavior as VDR does it in its
Makefile.
So if one compiles VDR without any option and has indirect set
REMOTE_KBD,
the plugin has the ability to give the error message on compile time.

Ok, I see the drawback in the case you have no Make.config file. If I
remove
the lines, the check on compile time is missing but the drawback is also
gone.

So I will remove it in the next release...

Till then I suggest you to use the Make.config file with the
corresponding
entry in it. So you don't have to set it each time you compile the
plugin.
Or remove it on your own.

> 
> * with gcc 3.2 i get the following error:
>   g++  -fPIC -Wall -Woverloaded-virtual -c 
> -DPLUGIN_NAME_I18N='"console"' 
>        -D_GNU_SOURCE -DREMOTE_LIRC -I/usr/include/vdr 
>        -I../../../../DVB/include console.c 
>   In file included from console.c:20: 
>   engine.h:278: friend declaration requires class-key, 
>   i.e. `friend struct cConsoles'
>   make: *** [console.o] Error 1
> 
>   When I change the declaration from "friend cConsoles" to 
>   "friend class cConsoles", everything works nicely.

Yes, Jürgen Zimmermann has already sent me a patch for this.
I repost it here for all others who has the same problem:

--- console-0.1.0/engine.h	2002-11-19 14:29:20.000000000 +0100
+++ console-0.1.0/engine.h.orig	2002-11-19 14:28:56.000000000 +0100
@@ -275,7 +275,7 @@
   public IWaitable
 {
 
-  friend cConsoles;
+  friend struct cConsoles;
 
 private:


Jan



--
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.