[vdr] Re: Fix: Timeshifting pb with vdr 1.1.32 / vdr-1.1.33

["Stephan Schreiber" <stephan@sschreiber.de>]

Klaus Schmidinger wrote:
> Please try the attached patch against recording.c.
> Take a fresh installation of the original VDR 1.1.33 to do this,
> so that the sleep(3) patch in menu.c is _not_ used.
>
> At least here on my system this seems to fix the problem with pressing
> "Play" immediately after pausing live video. There my be a short halt
> when starting replay, that's caused by the index file having to catch up
> far enough to ensure correct replay.
>
> Please let me know whether this works for you.
>
> Klaus

As I wrote before, it did not only occur when immediately starting replay,
but at least in my case it happened also after 1/2 hour or 5 minutes. Just
everytime.
It seems like it hit EOF already during pause (during that 1 second of
replay???)...
Maybe because tuning takes longer on a DVB-C card?

Anyway, your patch seems to fix it. The replay still stops sometimes after 2
minutes or so, which is even stranger, but most of the time it works.

Just out of curiosity:
Why is it so bad to just increase that first delay?

If I understood it correctly, what happens in PauseLiveVideo() is:

1.) we start an immediate recording on the current channel
2.) wait for 2 seconds, to allow some frames to be recorded
3.) start replay
4.) wait for 1 second to allow a still frame to be shown
5.) pause replay
[6.) wait for some seconds so the user cannot immediately start replay]

So, to me it seems totally logical that the delay under 2.) has to be high
enough, so we don't reach EOF already at 3.)....
And then it would make no difference how soon the replay is resumed. Fast
Forwarding to EOF is already being prevented....

But probably I'm missing something there.....


Greetings
Stephan



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.