[vdr] Re: Buffer Overflows in vdr-1.3.13

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Klaus Schmidinger wrote:
> 
> Klaus Schmidinger wrote:
> >
> > ...
> > The problem we are facing at the moment is that the remuxer's result
> > buffer runs full and doesn't get emptied any more. Presumably this
> > happens because it can't get any sync on useful data, hence the
> > additional debug output.
> 
> I believe I found what's causing the resultBuffer in cRemux to
> run full. This modification shoud fix it:
> 
> --- remux.c     2004/10/16 09:11:52     1.19
> +++ remux.c     2004/10/23 11:53:51
> @@ -597,7 +597,7 @@
>                 Count += l;
>                 }
>              else
> -               resultSkipped = i;
> +               resultSkipped = i + ((l > 0) ? l : 0);

Actually 'resultSkipped = i + l' should be ok, too, since 'l < 0' has
already been checked further above.

Klaus

>              if (l > 0)
>                 i += l - 1; // the loop increments, too
>              }
> 
> @C.Y.M: can you please test whether this fixes your problems with the
>         consecutive 1 minute timers? You should apply this patch to
>         the plain vanilla VDR 1.3.13 remux.c, without the workaround
>         that did "clearing resultBuffer before sync".
> 
> Klaus