V4L2-library

v4l2-library@linuxtv.org

81 discussions

Joint, on board :-)
by Thomas Kaiser 23 Feb '08

23 Feb '08

Hi You may read my name already on the V4l mail list. I am pleased to join this list :-) I just read http://www.linuxtv.org/v4lwiki/index.php/V4L2UserspaceLibrary (I did not look at the code, yet) Looks very good. But how you will get the raw stream from the V4l1/2 device? As far as I know, this is not defined by V4l. That's way I asked for V4L2_PIX_FMT_RAW on the v4l mail list. Thomas -- http://www.kaiser-linux.li

2 1

Re: [V4l2-library] [PATCH 4/4] v4l2_extension: grab real driver reference
by Thierry Merle 15 Feb '08

15 Feb '08

Thierry Merle a écrit : > Jiri Slaby a écrit : > >> From: Jiri Slaby <ku(a)bellona.localdomain> >> >> Before opening real backing device, make sure, it is there and not going away. >> Drop the reference after release and failing open. >> >> Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> >> --- >> > All this patch series is comitted in > http://linuxtv.org/hg/~tmerle/v4l2_extension , thanks. > > > -- > video4linux-list mailing list > Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe > https://www.redhat.com/mailman/listinfo/video4linux-list > > Argh, I did not notice, this patch series is for the v4l2 library, not for the v4l-dvb mainstream. Sorry people, wrong list :) Thierry

1 0

Dazzle Tv Mobile and Secam issue
by Кузнецов Андрей Сергеевич 23 Jan '08

23 Jan '08

Hello. I have dazzle tv mobile wich is detected by system as Pinnacle PCTV USB2 I installed latest dvb drivers, but via mplayer and kdetv picture from tv input with choosing norm(secam) picture is being b&w. However, Composite1 input in PAL works fine. I have OpenSUSE 10.3 with 2.6.22-13 0.3 kernel My tv file: alias char-major-81 videodev options em28xx card=3 i2c_scan=1 tuner=38 options i2c-algo-bit bit_test=1 alias char-major-81-0 off alias char-major-81-1 em28xx alias char-major-81-2 off alias char-major-81-3 off My dmesg skyline1:/etc/sysconfig # dmesg | grep em28xx em28xx v4l2 driver version 0.1.0 loaded em28xx new video device (2304:0208): interface 0, class 255 em28xx Has usb audio class em28xx #0: Alternate settings: 8 em28xx #0: Alternate setting 0, max size= 0 em28xx #0: Alternate setting 1, max size= 1024 em28xx #0: Alternate setting 2, max size= 1448 em28xx #0: Alternate setting 3, max size= 2048 em28xx #0: Alternate setting 4, max size= 2304 em28xx #0: Alternate setting 5, max size= 2580 em28xx #0: Alternate setting 6, max size= 2892 em28xx #0: Alternate setting 7, max size= 3072 em28xx #0: em28xx chip ID = 18 em28xx #0: i2c eeprom 00: 1a eb 67 95 04 23 08 02 10 00 1e 03 98 1e 6a 2e em28xx #0: i2c eeprom 10: 00 00 06 57 6e 00 00 00 8e 00 00 00 07 00 00 00 em28xx #0: i2c eeprom 20: 16 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 em28xx #0: i2c eeprom 30: 00 00 20 40 20 80 02 20 10 01 00 00 00 00 00 00 em28xx #0: i2c eeprom 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 em28xx #0: i2c eeprom 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 em28xx #0: i2c eeprom 60: 00 00 00 00 00 00 00 00 00 00 2e 03 50 00 69 00 em28xx #0: i2c eeprom 70: 6e 00 6e 00 61 00 63 00 6c 00 65 00 20 00 53 00 em28xx #0: i2c eeprom 80: 79 00 73 00 74 00 65 00 6d 00 73 00 20 00 47 00 em28xx #0: i2c eeprom 90: 6d 00 62 00 48 00 00 00 1e 03 50 00 43 00 54 00 em28xx #0: i2c eeprom a0: 56 00 20 00 55 00 53 00 42 00 32 00 20 00 50 00 em28xx #0: i2c eeprom b0: 41 00 4c 00 00 00 06 03 31 00 00 00 00 00 00 00 em28xx #0: i2c eeprom c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 em28xx #0: i2c eeprom d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 em28xx #0: i2c eeprom e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 em28xx #0: i2c eeprom f0: 00 00 00 00 00 00 00 00 0e 5d 62 35 03 ad 8f 26 em28xx #0: found i2c device @ 0x4a [saa7113h] em28xx #0: found i2c device @ 0x86 [tda9887] em28xx #0: found i2c device @ 0x8e [remote IR sensor] em28xx #0: found i2c device @ 0xa0 [eeprom] em28xx #0: found i2c device @ 0xc6 [tuner (analog)] saa7115' 1-0025: saa7113 found (1f7113d0e100000) @ 0x4a (em28xx #0) tuner' 1-0043: chip found @ 0x86 (em28xx #0) tuner' 1-0063: chip found @ 0xc6 (em28xx #0) em28xx #0: V4L2 device registered as /dev/video0 and /dev/vbi0 em28xx #0: Found Pinnacle PCTV USB 2 em28xx audio device (2304:0208): interface 1, class 1 em28xx audio device (2304:0208): interface 2, class 1 usbcore: registered new interface driver em28xx options tuner secam=d makes nothing

3 2

[PATCH 1/2] V4L: v4l2_extension: fix ext device name
by Jiri Slaby 11 Oct '07

11 Oct '07

# HG changeset patch # User Jiri Slaby <jirislaby(a)gmail.com> # Date 1192096703 -7200 # Node ID 4fbd75ec9acee9dc29de45491c6f3cee58b07076 # Parent 1f0b37d344c430ef09788f0193ada0ee08062447 v4l2_extension: fix ext device name update card name, not driver name, since it is, what is seen in the device list Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> diff -r 1f0b37d344c4 -r 4fbd75ec9ace linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c Thu Oct 11 12:01:10 2007 +0200 +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c Thu Oct 11 11:58:23 2007 +0200 @@ -151,7 +151,7 @@ static int vidioc_querycap(struct file * ret = base_dev->vidioc_querycap(&dev->fake_file, dev->fake_file.private_data, vc); - strlcpy(vc->driver, dev->vdev->name, sizeof(vc->driver)); + strlcpy(vc->card, dev->vdev->name, sizeof(vc->card)); } return ret; }

2 2

[PATCH 1/3] V4L: v4l2_extension: checkpatch fixups
by Jiri Slaby 07 Oct '07

07 Oct '07

# HG changeset patch # User Jiri Slaby <jirislaby(a)gmail.com> # Date 1191758673 -7200 # Node ID 14896a4d8f5d21d20b84dfd0a147c5a326f34599 # Parent 86d96d9bea4a26de43c0b7997cd751b49fe5ba0b v4l2_extension: checkpatch fixups yet another cleanups how checkpatch offers them Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c @@ -78,7 +78,7 @@ static int v4l2ext_hlp_open(struct inode /* allocate and initialize device private data structure */ dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (dev == NULL) { - printk("cannot allocate device.\n"); + printk(KERN_ERR "cannot allocate device.\n"); return -ENOMEM; } @@ -88,7 +88,8 @@ static int v4l2ext_hlp_open(struct inode return 0; } -static int v4l2ext_hlp_release(struct inode *inode, struct file *file) { +static int v4l2ext_hlp_release(struct inode *inode, struct file *file) +{ mutex_lock(&helper_daemon_lock); /* Helper daemon has gone */ @@ -100,8 +101,7 @@ static int v4l2ext_hlp_release(struct in return 0; } -static const struct file_operations v4l2ext_hlp_fops= -{ +static const struct file_operations v4l2ext_hlp_fops = { .owner = THIS_MODULE, .open = v4l2ext_hlp_open, .poll = v4l2ext_hlp_poll, @@ -142,7 +142,8 @@ err: return ret; } -void v4l2ext_hlp_fini(void) { +void v4l2ext_hlp_fini(void) +{ class_device_destroy(helper_class, MKDEV(helper_major, 0)); unregister_chrdev(helper_major, HELPER_IF_NAME); class_destroy(helper_class); diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c @@ -37,9 +37,9 @@ MODULE_LICENSE("GPL"); static unsigned int video_debug; module_param(video_debug, int, 0644); -MODULE_PARM_DESC(video_debug,"enable debug messages [video]"); - -#define dprintk(level,fmt, arg...) do { \ +MODULE_PARM_DESC(video_debug, "enable debug messages [video]"); + +#define dprintk(level, fmt, arg...) do { \ if (video_debug >= level) \ printk(KERN_DEBUG "v4l2_extension: " fmt, ## arg); \ } while (0) @@ -107,7 +107,7 @@ video_poll(struct file *file, struct pol struct video_device *base_dev = dev->base_vdev; if (base_dev->fops->poll) - return base_dev->fops->poll(&dev->fake_file,wait); + return base_dev->fops->poll(&dev->fake_file, wait); else return -EINVAL; } diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension.h b/linux/drivers/media/video/v4l2_extension/v4l2_extension.h --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension.h +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension.h @@ -30,7 +30,7 @@ #include <linux/version.h> #include <linux/mutex.h> -#define V4L2EXT_VERSION_CODE KERNEL_VERSION(0,0,1) +#define V4L2EXT_VERSION_CODE KERNEL_VERSION(0, 0, 1) /***************************************************************************/ /* v4l2 extension driver public interface */

2 4

Re: [V4l2-library] [PATCH 8/8] V4L: v4l2_extension: check for v4l2ext_hlp_init retval in v4l2ext_init
by Thierry Merle 07 Oct '07

07 Oct '07

Jiri Slaby wrote: > # HG changeset patch > # User Jiri Slaby <jirislaby(a)gmail.com> > # Date 1191678256 -7200 > # Node ID 86d96d9bea4a26de43c0b7997cd751b49fe5ba0b > # Parent a4e8124c6f90a766a49b2e042a757b31faeed8ee > v4l2_extension: check for v4l2ext_hlp_init retval in v4l2ext_init > > Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> > > diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > @@ -535,9 +535,7 @@ static int v4l2ext_init(void) > V4L2EXT_VERSION_CODE & 0xff); > > /* activate the v4l2 helper daemon interface */ > - v4l2ext_hlp_init(); > - > - return 0; > + return v4l2ext_hlp_init(); > } > > static void v4l2ext_fini(void) > > Patch committed at http://linuxtv.org/hg/~tmerle/v4l2_extension/ Thanks for this patch series, the code looks and behaves better. Thierry

1 0

Re: [V4l2-library] [PATCH 7/8] V4L: v4l2_extension: use list_for_each_entry istead of list_for_each
by Thierry Merle 07 Oct '07

07 Oct '07

Jiri Slaby wrote: > # HG changeset patch > # User Jiri Slaby <jirislaby(a)gmail.com> > # Date 1191677598 -7200 > # Node ID a4e8124c6f90a766a49b2e042a757b31faeed8ee > # Parent f89a5dbbfcf7706106d46d0702659e84db9f33df > v4l2_extension: use list_for_each_entry istead of list_for_each > > Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> > > diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > @@ -60,18 +60,16 @@ static int video_open(struct inode *inod > static int video_open(struct inode *inode, struct file *file) > { > int minor = iminor(inode); > - struct v4l2ext *h; > - struct v4l2ext *dev = NULL; > - struct list_head *list; > + struct v4l2ext *h, *dev = NULL; > struct video_device *base_dev; > > /* Find the right private data corresponding to this inode */ > - list_for_each(list,&v4l2ext_devlist) { > - h = list_entry(list, struct v4l2ext, devlist); > + list_for_each_entry(h, &v4l2ext_devlist, devlist) > if (h->vdev->minor == minor) { > dev = h; > + break; > } > - } > + > if (dev == NULL) > return -ENODEV; > > @@ -545,16 +543,14 @@ static void v4l2ext_fini(void) > static void v4l2ext_fini(void) > { > struct v4l2ext *h; > - struct list_head *list; > > /* remove the v4l2 helper daemon interface */ > v4l2ext_hlp_fini(); > > /* remove any registered base v4l structure */ > - list_for_each(list, &v4l2ext_devlist) { > - h = list_entry(list, struct v4l2ext, devlist); > + list_for_each_entry(h, &v4l2ext_devlist, devlist) > v4l2ext_unregister(h->base_vdev); > - } > + > printk(KERN_INFO "v4l2 extension module removed\n"); > } > > @@ -671,19 +667,17 @@ out: > /* and the corresponding 'clone' device entry point */ > void v4l2ext_unregister(struct video_device *base_vdev) > { > - struct v4l2ext *h; > - struct v4l2ext *dev = NULL; > - struct list_head *list; > + struct v4l2ext *h, *dev = NULL; > > mutex_lock(&v4l2ext_lock); > > /* find the corresponding entry in device list */ > - list_for_each(list,&v4l2ext_devlist) { > - h = list_entry(list, struct v4l2ext, devlist); > + list_for_each_entry(h, &v4l2ext_devlist, devlist) { > /* FIXME: The way to match the corresponding entry is not > optimized and uncertain */ > if (h->base_vdev->fops == base_vdev->fops) { > - dev = h; > + dev = h; > + break; > } > } > if (dev != NULL) { > > Patch committed at http://linuxtv.org/hg/~tmerle/v4l2_extension/ Thierry

1 0

Re: [V4l2-library] [PATCH 6/8] V4L: v4l2_extension: aiee, don't deref NULL on fail path in v4l2ext_register
by Thierry Merle 07 Oct '07

07 Oct '07

Jiri Slaby wrote: > # HG changeset patch > # User Jiri Slaby <jirislaby(a)gmail.com> > # Date 1191677283 -7200 > # Node ID f89a5dbbfcf7706106d46d0702659e84db9f33df > # Parent 210b62fbf40aba1dc223da3c47c2db4650dc0ac6 > v4l2_extension: aiee, don't deref NULL on fail path in v4l2ext_register > > Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> > > diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > @@ -657,11 +657,12 @@ int v4l2ext_register(struct video_device > /* Error case, cleanup what must be cleaned */ > out_free: > v4l2ext_devused &= ~(1 << nr); > - if (dev) > + if (dev) { > video_device_release(dev->vdev); > + kfree(dev->fake_file.f_dentry); > + } > + kfree(fake_inode); > kfree(dev); > - kfree(fake_inode); > - kfree(dev->fake_file.f_dentry); > out: > return ret; > } > > Patch committed at http://linuxtv.org/hg/~tmerle/v4l2_extension/ Thierry

1 0

Re: [V4l2-library] [PATCH 5/8] V4L: v4l2_extension: proper v4l2ext_lock locking in v4l2ext_register
by Thierry Merle 07 Oct '07

07 Oct '07

Jiri Slaby wrote: > # HG changeset patch > # User Jiri Slaby <jirislaby(a)gmail.com> > # Date 1191675980 -7200 > # Node ID 210b62fbf40aba1dc223da3c47c2db4650dc0ac6 > # Parent a39992015edfc30818c224d1886dc8311bc3106b > v4l2_extension: proper v4l2ext_lock locking in v4l2ext_register > > don't allow two releases of the lock on fail path > > Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> > > diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c > @@ -575,7 +575,8 @@ int v4l2ext_register(struct video_device > printk(KERN_ERR "This driver supports only %d device " > "creations\n", V4L2EXT_MAXDEV); > ret = -ENOSPC; > - goto out_unlock; > + mutex_unlock(&v4l2ext_lock); > + goto out; > } > > /* reserve this entry */ > @@ -661,10 +662,7 @@ int v4l2ext_register(struct video_device > kfree(dev); > kfree(fake_inode); > kfree(dev->fake_file.f_dentry); > - > - out_unlock: > - mutex_unlock(&v4l2ext_lock); > - > +out: > return ret; > } > > > Patch committed at http://linuxtv.org/hg/~tmerle/v4l2_extension/ Thierry

1 0

Re: [V4l2-library] [PATCH 4/8] V4L: v4l2_extension: hlp_init/exit cleanup
by Thierry Merle 07 Oct '07

07 Oct '07

Jiri Slaby wrote: > # HG changeset patch > # User Jiri Slaby <jirislaby(a)gmail.com> > # Date 1191675459 -7200 > # Node ID a39992015edfc30818c224d1886dc8311bc3106b > # Parent d1d8e50056430b80d13f729e4a87dfb5ffee58dc > v4l2_extension: hlp_init/exit cleanup > > use helper_major, not major 0 (as it is not 0), check for proper error value > returned by class_create (it doesn't return NULL, but ERR_PTR encoded retval). > also propagate the retval one layer upper. > > Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> > > diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c > --- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c > +++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-hlp.c > @@ -112,17 +112,23 @@ static const struct file_operations v4l2 > > int v4l2ext_hlp_init(void) > { > + int ret; > + > /* Unnamed device creation */ > - helper_major = register_chrdev(0, HELPER_IF_NAME, &v4l2ext_hlp_fops); > - if (helper_major < 0) { > - printk(KERN_WARNING "v4l2_extension: unable to get major\n"); > - return -EIO; > + ret = register_chrdev(0, HELPER_IF_NAME, &v4l2ext_hlp_fops); > + if (ret < 0) { > + printk(KERN_ERR "v4l2_extension: unable to get major\n"); > + goto err; > } > + helper_major = ret; > > /* create a driver class in order to automate udev */ > helper_class = class_create(THIS_MODULE, HELPER_IF_NAME); > - if (!helper_class) > - return -EINVAL; > + if (IS_ERR(helper_class)) { > + printk(KERN_ERR "v4l2_extension: unable to create a class\n"); > + ret = PTR_ERR(helper_class); > + goto err_unr; > + } > > class_device_create(helper_class, > NULL, > @@ -130,11 +136,15 @@ int v4l2ext_hlp_init(void) > NULL, HELPER_IF_NAME); > > return 0; > +err_unr: > + unregister_chrdev(helper_major, HELPER_IF_NAME); > +err: > + return ret; > } > > void v4l2ext_hlp_fini(void) { > class_device_destroy(helper_class, MKDEV(helper_major, 0)); > - unregister_chrdev(0, HELPER_IF_NAME); > + unregister_chrdev(helper_major, HELPER_IF_NAME); > class_destroy(helper_class); > } > /* ----------------------------------------------------------- */ > > Patch committed at http://linuxtv.org/hg/~tmerle/v4l2_extension/ Thierry

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

V4L2-library