[linux-dvb] Re: [PATCH] Update FE_DISHNETWORK_SEND_LEGACY_CMD for current kernels

Johannes Stezenbach js at linuxtv.org
Sun Apr 3 21:39:05 CEST 2005


On Sun, Mar 27, 2005 at 02:21:54PM -0800, NooneImportant wrote:
> Johannes Stezenbach wrote:
> > On Sun, Mar 27, 2005 at 11:27:49AM -0800, NooneImportant wrote:
> >> The following patch fixes the current stv0299 code that handles
> >> FE_DISHNETWORK_SEND_LEGACY_CMD.
> >> (This code supports the legacy SW21, SW44, and SW64 switches)
> >
> > Would you mind to do some clean ups?
> 
> Sure.  Sorry, I'm usually better about paying attention to coding styles.
> 
> >> +static int debug_dn_switch;
> >
> >> I would suggest "debug_dish_network".
> 
> I chose 'debug_legacy_dish_switch'  It is longer, but many
> dish-network users won't be using these old-style switches, so I don't
> want to mislead them.
> 
> I think I fixed all the rest of the issues you raised; I hope this is
> more to your liking.

Yes. Sorry for the delay.

Comitted.

Thanks,
Johannes




More information about the linux-dvb mailing list