[linux-dvb] [PATCH] removal of redundant code in bttv!, was [PATCH] bttv freeze fix

Nigel Pearson nigel at ind.tansu.com.au
Tue Apr 5 01:54:21 CEST 2005


> --- bttv-cards.c.orig	2005-04-04 16:27:34.000000000 +0400
> +++ bttv-cards.c	2005-04-04 16:26:41.000000000 +0400
> @@ -2718,8 +2718,6 @@ void __devinit bttv_init_card2(struct bt
>          }
>  	btv->pll.pll_current = -1;
>
> -	bttv_reset_audio(btv);
> -
>  	/* tuner configuration (from card list / autodetect / insmod option) 
> */
>   	if (UNSET != bttv_tvcards[btv->c.type].tuner_type)
>  		if(UNSET == btv->tuner_type)

	No hang on my 2.6.11, Aver 771 + TwinHan VisionPlus test rig.
Maybe this deserves a comment in the source?

-	bttv_reset_audio(btv);
+	/* The following reset causes kernel hangs with some DVB cards which 
use
+	 * bt8xx style audio DMA for other purposes (e.g. TwinHan VisionPlus).
+	bttv_reset_audio(btv);
+	 * Resetting the audio on bt8xx cards is not necessary,
+	 * because the audio drivers should do that when they open the card?
+	 */


Now, how do we get this into 2.6.11.7 (or whatever the next one is)?

--
Nigel Pearson, nigel at ind.tansu.com.au | "Now the world has gone to bed,
Telstra BI&D, Sydney, Australia       |  Darkness won't engulf my head,
Office: 8255 4222    Fax:  8255 3153  |  I can see by infrared,
Mobile: 0408 664435  Home: 9792 6998  |  How I hate the night." -Marvin





More information about the linux-dvb mailing list