[linux-dvb] [PATCH] Nebula DVB-T with MT352 Frontend

Johannes Stezenbach js at linuxtv.org
Thu Aug 4 15:03:59 CEST 2005


David Johnson wrote:
> On Wednesday 03 August 2005 23:55, Johannes Stezenbach wrote:
> >
> > Just one comment:
> > > +  /*
> > > +   * It is possible to determine the correct frontend using the I2C bus
> > > (see the Nebula SDK); +   * this would be a cleaner solution than trying
> > > each frontend in turn. +   */
> >
> > IMHO this isn't cleaner. You would move (or, worse, copy) the
> > frontend-specific probing code from the frontend driver to the card
> > driver. In the long run this is a maintenance nightmare.
> >
> 
> This method of detecting the frontend involves simply reading a register value 
> from the card over the I2C bus. Is there not an easy way to do this without 
> moving code around?
> (btw, I know  very little about how the I2C bus works and even less about how 
> to use it within the kernel, so my apologies if I'm completely wrong...)

For the Nebula it may be that simple, but in the general case there
might be more work to do (e.g. first make sure the demod is not
in sleep state, need to probe PLL seperately etc.). Every time
there's a new Nebula version the code needs updateing and gets more
complex...

Johannes




More information about the linux-dvb mailing list