[linux-dvb] AC3 support for szap with firmware 0x2622

Johannes Stezenbach js at linuxtv.org
Sun Dec 18 20:58:06 CET 2005


On Mon, Dec 12, 2005, Dr. Werner Fink wrote:
> On Sat, Dec 10, 2005 at 07:56:20PM +0100, Johannes Stezenbach wrote:
> > On Wed, Dec 07, 2005, Dr. Werner Fink wrote:
> > > just a few changes to the current szap found in the CVS of
> > > linuxtv.org to support TV channels with AC3 audio channels.
> > 
> > > +      if ((audiofd = open(auddev, O_RDWR)) < 0) {
> > >  	 perror("opening audio demux failed");
> > > -	 close(videofd);
> > > +	 close(dmxfd);
> > >  	 close(fefd);
> > >  	 return FALSE;
> > >        }
> > 
> > It seems you open the audio device unconditionally which makes
> > this patch incompatible with budget cards.
> > 
> > Can you fix that up?
> 
> Hopefully it is OK to test for dvr == 0 and use audiofd == -1 to detect
> failed opening of the audio device.  I've also added a patch for some
> cleanings to test_audio.c, test_front.c , test_switch.c, and
> test_video.c in a second patch.

All patches comitted.

Johannes



More information about the linux-dvb mailing list