[linux-dvb] Linux DVB on Mac PowerPC (Yellow Dog Linux - Freecom USB and DEC2000-t)

[Tim Hewett]

Johannes,

I tried your patch on the latest CVS of ttusb_dec.c. I'm not
sure whether you intended it to be a fix for the PPC byte
ordering problem but if you did then it isn't fixed. This is
what is shown in dmesg when the DEC2000 is connected:

usb 3-1: new full speed USB device using ohci_hcd and address 2
ttusb_dec_probe: invalid product id 0810

Regards,

Tim.


On 18 Dec 2005, at 19:06, Johannes Stezenbach wrote:

> diff -u -p -r1.77 ttusb_dec.c
> --- linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c	9 Dec 2005  
> 21:53:00 -0000	1.77
> +++ linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c	18 Dec 2005  
> 18:48:19 -0000
> @@ -1601,6 +1601,7 @@ static int ttusb_dec_probe(struct usb_in
>  {
>  	struct usb_device *udev;
>  	struct ttusb_dec *dec;
> +	int rc;
>
>  	dprintk("%s\n", __FUNCTION__);
>
> @@ -1627,15 +1628,23 @@ static int ttusb_dec_probe(struct usb_in
>  	case 0x1009:
>  		ttusb_dec_set_model(dec, TTUSB_DEC2540T);
>  		break;
> +	default:
> +		printk("%s: invalid product id %04x\n",
> +		       __FUNCTION__, le16_to_cpu(id->idProduct));
> +		kfree(dec);
> +		return -ENXIO;
>  	}
>
>  	dec->udev = udev;
>
> -	if (ttusb_dec_init_usb(dec))
> -		return 0;
> -	if (ttusb_dec_init_stb(dec)) {
> +	if ((rc = ttusb_dec_init_usb(dec))) {
> +		kfree(dec);
> +		return rc;
> +	}
> +	if ((rc = ttusb_dec_init_stb(dec))) {
>  		ttusb_dec_exit_usb(dec);
> -		return 0;
> +		kfree(dec);
> +		return rc;
>  	}
>  	ttusb_dec_init_dvb(dec);
>
> @@ -1649,6 +1658,8 @@ static int ttusb_dec_probe(struct usb_in
>  	case 0x1009:
>  		dec->fe = ttusbdecfe_dvbt_attach(&fe_config);
>  		break;
> +	default:
> +		BUG();
>  	}
>
>  	if (dec->fe == NULL) {
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.linuxtv.org/pipermail/linux-dvb/attachments/20051219/1c01ad25/attachment.htm