[linux-dvb] Re: [PATCH] Remove #ifdef BTTV_BOARD_TWINHAN_VP3021

Manu Abraham abraham.manu at gmail.com
Tue Dec 20 18:04:15 CET 2005


Hello Mike,



Michael Krufky wrote:

> Manu-
>
> I've always wondered what the following code was for:
>
> #ifdef BTTV_BOARD_TWINHAN_VP3021
>     case BTTV_BOARD_TWINHAN_VP3021:
> #else
>     case BTTV_BOARD_NEBULA_DIGITV:
> #endif
>
>
> ...I figured it was for backwards compatability with some older v4l 
> snapshot, but I see no mention of BTTV_TWINHAN_VP3021 anywhere in the 
> video4linux cvs revision history.
>

This part of the code is not for the Twinhan board itself. This is a 
remnant from the FE_REFACTORING period. This code is wrongly commented 
as Twinhan VP3021 itself in the first place. It is in fact actually for 
the NXT6000,for the Nebula DigiTV not for the Twinhan.

In fact, i talked about this to Andrew, who worked on that. At that 
point of time he asked me to change the code if necessary, but i thought 
i would leave it alone at that point of time.

> ...even if it WAS used at one point, these #ifdef's are no longer 
> necessary, due to the v4l/dvb cvs merger.
>
> Is there any reason why NOT to apply this to cvs?


I don't see any reason why it should not be, since i feel that it should 
be a simple

    case NEBULA_DIGITV:

>
> (please respond with ACK or NACK)
>



Acked-by: Manu Abraham <manu at linuxtv.org>



>
>------------------------------------------------------------------------
>
>[PATCH] Remove #ifdef BTTV_BOARD_TWINHAN_VP3021
>
>As far back as the video4linux cvs repository goes, there is no mention 
>of BTTV_TWINHAN_VP3021.  It seems that this was done for the sake of 
>backwards compatability with some older v4l, but this can no longer be 
>necessary due to the v4l/dvb cvs merger.
>
>Signed-off-by: Michael Krufky <mkrufky at m1k.net>
>
> dvb-bt8xx.c |    8 --------
> 1 files changed, 8 deletions(-)
>
>Index: v4l-dvb/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c
>===================================================================
>--- v4l-dvb.orig/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c	2005-12-20 11:17:10.924675416 -0500
>+++ v4l-dvb/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c	2005-12-20 11:17:14.865076384 -0500
>@@ -616,11 +616,7 @@
> 			dprintk ("dvb_bt8xx: lgdt330x detected\n");
> 		break;
> 
>-#ifdef BTTV_BOARD_TWINHAN_VP3021
>-	case BTTV_BOARD_TWINHAN_VP3021:
>-#else
> 	case BTTV_BOARD_NEBULA_DIGITV:
>-#endif
> 		/*
> 		 * It is possible to determine the correct frontend using the I2C bus (see the Nebula SDK);
> 		 * this would be a cleaner solution than trying each frontend in turn.
>@@ -824,11 +820,7 @@
> 		card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
> 		break;
> 
>-#ifdef BTTV_BOARD_TWINHAN_VP3021
>-	case BTTV_BOARD_TWINHAN_VP3021:
>-#else
> 	case BTTV_BOARD_NEBULA_DIGITV:
>-#endif
> 	case BTTV_BOARD_AVDVBT_761:
> 		card->gpio_mode = (1 << 26) | (1 << 14) | (1 << 5);
> 		card->op_sync_orin = 0;
>  
>




More information about the linux-dvb mailing list