[linux-dvb] Re: DEC2000-t/Kernel 2.6.10: Badness in usb_unlink_urb

[C Western]

Nyk Tarr wrote:
> On Sun, Jan 09, 2005 at 11:59:18AM +0100, Peter Daum wrote:
> 
>>Hi,
>>
>>after a long break (for previous experiences see the discussions following
>>http://www.linuxtv.org/mailinglists/linux-dvb/2004/06-2004/msg00379.html),
>>I just tried, whether there has been any progress with the DEC 2000-t
>>usb box. The result was pretty much the same as with earlier attempts.
>>
>>What is new, is that Kernel 2.6.10 floods the syslog with stack traces
>>complaining about a "Badness in usb_unlink_urb". Attached below are
>>the messages right after connecting the box. Pretty much any action
>>regarding the device will yield some more of these messages. Maybe the
>>stack trace can bring enlightenment ...
>>
>>Note, that these kernel messages do not seem to reflect any new
>>problem - everything still works as good or bad as described before
>>(except reading from /dev/dvb/adapter0/dvr0 usually works). For most
>>practical purposes it's still almost useless, because after some
>>channel changes the box inevitably will die :-(
> 
> 
> 
> I don't have the problem (cvs+2.6.10-ac7), but this patch shut up the
> BUG() (or whatever it is).
> 
> Use at your own risk - I'm ot a programmer ^_^
In the same spirit I attach a patch for ttusb-budget.c that works for me
Colin
-------------- next part --------------
--- ./media/dvb/ttusb-budget/dvb-ttusb-budget.c.orig	2005-01-21 14:45:06.000000000 +0000
+++ ./media/dvb/ttusb-budget/dvb-ttusb-budget.c	2005-02-12 23:03:29.000000000 +0000
@@ -832,7 +832,7 @@
 	int i;
 
 	for (i = 0; i < ISO_BUF_COUNT; i++)
-		usb_unlink_urb(ttusb->iso_urb[i]);
+		usb_kill_urb(ttusb->iso_urb[i]);
 
 	ttusb->iso_streaming = 0;
 }