[linux-dvb] Re: [REVISED -mm PATCH] v4l: add dvb support for dvico
js at linuxtv.org
Tue Jul 5 23:44:35 CEST 2005
Michael Krufky wrote:
> The attached patch has been revised to correct the sync byte for MPEG-2
> transport stream packets. Detailed changelog is included in the header
> of the patch.
> - Let Kconfig decide whether to include frontend-specific code in cx88-dvb.
> linux/drivers/media/dvb/frontends/dvb-pll.c | 13 ++++
> linux/drivers/media/dvb/frontends/dvb-pll.h | 1
> linux/drivers/media/video/cx88/cx88-cards.c | 3 -
> linux/drivers/media/video/cx88/cx88-dvb.c | 57 ++++++++++++++------
> linux/drivers/media/video/cx88/cx88-mpeg.c | 8 +-
Besides that the patch lacks the Kconfig changes which
would make the #ifdef mess useful, I still advise
against it. It is just not userfriendly if you require
users to find out what frontend driver the need for their card.
We had that in the past, and I think most people like
the current approach better.
just my 2¢,
More information about the linux-dvb