[linux-dvb] cx24110 driver question/problem

[Johannes Stezenbach]

On Sat, Jul 23, 2005 Adam Szalkowski wrote:
> On Tuesday 19 July 2005 19:52, Peter Hettkamp wrote:
> > Can you try to remove the setting for register 77 from send_burst but keep
> > the CHANGED line in send_msg? I'd expect this to work, if not something
> > really strange may be going on.
> 
> Removing the lines from send_burst makes the driver work again as expected.
> After some experiments I have maybe found a solution to this without removing 
> any code: I just added a msleep(200) right after the resetting of register 77 
> in send_diseqc_msg. 200 was the first value I tried, just to be sure it is 
> enough.

Is the patch below what you meant? If yes, can you try a smaller
msleep, maybe 15 msecs?

Index: drivers/media/dvb/frontends/cx24110.c
===================================================================
RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/frontends/cx24110.c,v
retrieving revision 1.26
diff -u -p -r1.26 cx24110.c
--- drivers/media/dvb/frontends/cx24110.c	17 Jul 2005 20:56:25 -0000	1.26
+++ drivers/media/dvb/frontends/cx24110.c	24 Jul 2005 20:28:58 -0000
@@ -398,7 +398,7 @@ static int cx24110_diseqc_send_burst(str
 		return -EINVAL;
 
 	rv = cx24110_readreg(state, 0x77);
-	cx24110_writereg(state, 0x77, rv|0x04);
+	cx24110_writereg(state, 0x77, rv | 0x04);
 
 	rv = cx24110_readreg(state, 0x76);
 	cx24110_writereg(state, 0x76, ((rv & 0x90) | 0x40 | bit));
@@ -418,7 +418,8 @@ static int cx24110_send_diseqc_msg(struc
 		cx24110_writereg(state, 0x79 + i, cmd->msg[i]);
 
 	rv = cx24110_readreg(state, 0x77);
-	cx24110_writereg(state, 0x77, rv|0x04);
+	cx24110_writereg(state, 0x77, rv & ~0x04);
+	msleep(200);
 
 	rv = cx24110_readreg(state, 0x76);
 


Johannes