[linux-dvb] Re: [PATCH] DViCO FusionHDTV3 Gold - add dvb support

[Michael Krufky]

Mac Michaels wrote:

>On Wednesday 15 June 2005 08:07 pm, Michael Krufky wrote:
>  
>
>>It took me over an hour to patch this code against
>>video4linux cvs (while eating chinese food and being
>>bombarded by instant-messages).
>>    
>>
>Well that was a waste of my time. I was originally making 
>patches against the video4linux CVS. 
>
>Based on some of the responses to my post of my first patch 
>I thought I was not supposed to make patches for 
>video4linux CVS because this is a dvb driver. So I got the 
>mm kernel and merged everything into that at the proper 
>locations to create the patch I started this thread with. 
>
>I also worked out the Kconfig stuff so that you could select 
>the driver with a kernel configuration program. While doing 
>this I discovered the nasty little secret that makes it 
>impossible to create a cx88-dvb that is configured for only 
>one of the dvb drivers.
>
Mac-

You didn't waste any of your time...  The Kconfig stuff will be 
necessary eventually, when the card goes into -mm.  Anyhow, I'm the new 
guy... just because I say something doesn't mean that I am necessarily 
correct.... I just think I am ;-)  I've been trying to act rather 
quickly on your posts for obvious selfish reasons (to support my own 
lgdt3302)  :-) ... That's why I did all this... Who knows... maybe I am 
out-of-line.

Recent policy prefers that changes get to cvs first before going into 
-mm ... In order to make that happen, I had to make the patch apply 
against current video4linux... I bet we did some double-work here.  I 
figured that I would post the patch on the list so it's all nice and 
ready, and then speak to the other developers at some point in irc (or 
over email), make a decision, and then commit it to cvs...

Meanwhile, I personally don't know much about DVB at all.... and I'm a 
night owl -- so I thought I'd take a look and give my two cents.  I bet 
you that when the other developers see this thread tomorrow they will 
tell us that the stuff must go into DVB  ... Honestly, I dont have a 
clue about that stuff.  However, I do know that the or51132 and cx22702 
are currently in v4l.  Since this is a cx88 card, I personally I believe 
that the lgdt3302 can live in v4l for a bit until we figure out how to 
bridge between v4l and dvb.  ... but that is just my opinion.

Also, I'm wondering if you could do me a favor... I am hoping to resolve 
an issue with regards to improper HUE settings with cx88 cards... When 
you are watching analog tv with your board, do you have to adjust the 
picture settings in order to get a decent picture?  Many cx88 boards 
require that the hue be set to 0% or 100% (in tvtime)  in order to get 
realistic colors.... We are collecting information on the v4l wiki - 
http://linuxtv.org/v4lwiki/index.php/Hue_Saturation_Brightness - could 
you please add your settings to the list, or at least email them to me 
so that I can add them?  Even if your settings work correctly 
out-of-the-box, I need to know that information as well... I have an 
easy way to fix this problem, but I just want to make sure that I'm not 
breaking other cards in the process.

Thanks again.

-- 
Michael Krufky