[linux-dvb] [PATCH] Twinhan + clones : Correct polarization for the DST frontend

Manu Abraham manu at kromtek.com
Tue Jun 21 10:42:12 CEST 2005


Olaf Titz wrote:
>>+            state->tx_tuna[8] =~ 0x40;  //1
>>+            state->tx_tuna[8] |= 0x40;  // 0
> 
> I don't know anything about that device, but this code looks wrong to
> me. The "1" line sets the whole register and the "0" line a single
> bit. Shouldn't that rather be something like
> 
>>+            state->tx_tuna[8] &= ~0x40;  //1
> 

Yep, that's the correct one .. The reason why the earlier patched worked 
for Allan was that the rest of the bits in the register are Don't care 
terms for his card ..

So setting the entire register to 0x00 worked for him.. For some of the 
other cards, they do test both horizontal and vertical polarities if 
none is supplied ..

Sorry, for the confusion added ..

Manu





More information about the linux-dvb mailing list