[linux-dvb] [PATCH] dmxdev.c some possible cleanups

Stefan Seyfried seife at gmane0305.slipkontur.de
Tue Jun 21 21:51:32 CEST 2005


On Tue, Jun 21, 2005 at 03:36:07PM +0200, Peter Beutner wrote:
> Hi
> the patch removes the following things:

> - in the following code:
>     if (!dmxdevfilter->feed.sec)
>          break;
>      dvb_dmxdev_feed_stop(dmxdevfilter);
>     if (dmxdevfilter->filter.sec)
>   The second check is senseless as it is only reached if 
> dmxdevfilter->filter.sec is not NULL.

At least a comment why checking for !dmxdevfilter->feed.sec is also
safe for dmxdevfilter->filter.sec would not be too bad (it is not
obvious to me, although i must admit that i have never looked into
the dmxdev code).
-- 
Stefan Seyfried





More information about the linux-dvb mailing list