[linux-dvb] Bug found in dvb-usb driver for avermedia

[Andrew Hodgson]

Thanks for you quick reply. Attached are the diffs for a800.c and
dvb-usb-remote.c. The changes to a800.c are trivial just a few errors
in the remote control codes.

There are 2 changes to dvb-usb-remote.c. The one around line 160 is
clearly a bug which
will stop all dvb-usb remotes from working since
                sizeof(keymap)/sizeof(struct dvb_usb_rc_key) is always == 0

 -                       for (i = 0; i < sizeof(keymap)/sizeof(struct
dvb_usb_rc_key); i++)
+                       for (i = 0; i < d->props.rc_key_map_size; i++) {

The other change was to make auto repeat work. Hope this helps and
thanks for the great work. The dvb-usb box works wonderfully better
than the PCI card which always had overheating problems

Andrew



On 6/24/05, Patrick Boettcher <patrick.boettcher at desy.de> wrote:
> Hi Andrew,
> 
> On Fri, 24 Jun 2005, Andrew Hodgson wrote:
> >   I hope this is the correct email to ask this question. I am new t
> > this area and mailing list.
> 
> It is correct.
> 
> >   I recently got an avermedia dvb-t usb2 tuner and installed the
> > latest dvb-kernel.
> >
> >   The tuner worked really well. I was a little disappointed that even
> > though there seem to be code to support the remote control it did not
> > work.
> >
> >   Last weekend I had some time to debug it and found 3 minor errors
> > in a800.c and one major bug in dvb-usb-remote.c.
> >
> >   I believe the bug in dvb-usb-remote.c would stop all dvb-usb
> > remotes from working.
> 
> Please create a diff (cvs diff -u) and send the output (with comments) to
> the list. It'll be appreciated.
> 
> Problem e.g. with the AverMedia is, that I only can rely on users
> comments, because I don't have this box for myself. This is problematic,
> because it is not just a simple clone of the ones I have here for testing.
> 
> Thanks in advance for posting your patches,
> Patrick.
> 
> --
>    Mail: patrick.boettcher at desy.de
>    WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvb-usb-remote.c.diffs
Type: application/octet-stream
Size: 1574 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20050626/ad2cfe7b/dvb-usb-remote.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a800.c.diffs
Type: application/octet-stream
Size: 1417 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20050626/ad2cfe7b/a800.c.obj