[linux-dvb] Re: [PATCH] LGDT3302 Frontend Driver

Michael Krufky mkrufky at m1k.net
Tue Jun 28 13:49:52 CEST 2005


Johannes Stezenbach wrote:

>Michael Krufky wrote:
>  
>
>>This driver for the LGDT3302 frontend, used by the DViCO FusionHDTV3 
>>Gold cx88-based hybrid analog/dvb pci card was written by Mac Michaels, 
>>and is currently in the video4linux CVS.  Please apply this to DVB 
>>kernel as soon as possible.
>>
>>Signed-off-by: Mac Michaels <wmichaels1 at earthlink.net> 
>>Signed-off-by: Michael Krufky <mkrufky at m1k.net> 
>>    
>>
>
>  
>
>>+#define dprintk(args...) \
>>+do { \
>>+if (debug) printk(KERN_DEBUG "lgdt3302: " args); \
>>+} while (0)
>>    
>>
>
>Interesting formatting...
>
>This patch adds a lot of whitespace at end-of-line. After you
>cleaned that up, please commit it to CVS by yourself, adding
>the Signed-off-by: lines to the commit message.
>
>Thanks,
>Johannes
>  
>
I checked with the original author of this code about the above strange 
formatting, and got many replies from other people...

Alex Deucher wrote:

>The back slashes at the end are so that you can split up a macro
>across multiple lines.  Do not remove them or the code will break. 
>The C preprocessor will append all the lines with backslashes onto one
>line.
>http://en.wikipedia.org/wiki/C_preprocessor
>  
>
Mauro Chehab told me (in irc) that the coding style used above DOES 
comply with Linus' kernel standards.

ALSO, about the whitespace, I only see some whitespace on some 
newlines... I will happy to clean that up.  I didn't realize that I have 
write access to linux-dvb, but I just tested and my account works.  
Thank you for the go-ahead, I will commit this after I clean it up.

-- 
Michael Krufky





More information about the linux-dvb mailing list