[linux-dvb] Re: [PATCH] LGDT3302 Frontend Driver

Michael Krufky mkrufky at m1k.net
Tue Jun 28 14:03:10 CEST 2005


castet.matthieu at free.fr wrote:

>Hi,
>
>Selon Michael Krufky <mkrufky at m1k.net>:
>
>>Johannes Stezenbach wrote:
>>
>>>Michael Krufky wrote:
>>>      
>>>
>>>>+#define dprintk(args...) \
>>>>+do { \
>>>>+if (debug) printk(KERN_DEBUG "lgdt3302: " args); \
>>>>+} while (0)
>>>>
>>>Interesting formatting...
>>>      
>>>
>Yes but why do you need do {} while(0) stuff ?
>You don't need to declare a new block as you add only a if statement, so
>  
>
>>>+#define dprintk(args...) if (debug) printk(KERN_DEBUG "lgdt3302: " args)
>>>      
>>>
>will be a lot's of cleanner...
>
>
>Matthieu
>  
>
Agreed... I will add make that change.

-- 
Michael Krufky





More information about the linux-dvb mailing list