[linux-dvb] Re: [PATCH] LGDT3302 Frontend Driver

Johannes Stezenbach js at linuxtv.org
Tue Jun 28 15:10:41 CEST 2005


Michael Krufky wrote:
> Johannes Stezenbach wrote:
> >Michael Krufky wrote:
> >>+#define dprintk(args...) \
> >>+do { \
> >>+if (debug) printk(KERN_DEBUG "lgdt3302: " args); \
> >>+} while (0)
> >>   
> >
> >Interesting formatting...
> >
> I checked with the original author of this code about the above strange 
> formatting, and got many replies from other people...
> 
> Alex Deucher wrote:
> 
> >The back slashes at the end are so that you can split up a macro
> >across multiple lines.  Do not remove them or the code will break. 
> >The C preprocessor will append all the lines with backslashes onto one
> >line.
> >http://en.wikipedia.org/wiki/C_preprocessor
> > 
> >
> Mauro Chehab told me (in irc) that the coding style used above DOES 
> comply with Linus' kernel standards.

I merely said the formatting is "interesting", as in "I wouldn't
have done it that way, but if it looks good to you...".

> ALSO, about the whitespace, I only see some whitespace on some 
> newlines... I will happy to clean that up.

If you use vim you can add "let c_space_errors=1" in your .vimrc
(I'm quite sure emacs has a similar feature), then delete everything
which is red.

Johannes




More information about the linux-dvb mailing list