[linux-dvb] Re: [PATCH] LGDT3302 Frontend Driver

Tomi Ollila tomi.ollila at iki.fi
Tue Jun 28 15:37:30 CEST 2005


Michael Krufky <mkrufky at m1k.net> writes:

> Johannes Stezenbach wrote:
>
>>
>>If you use vim you can add "let c_space_errors=1" in your .vimrc
>>(I'm quite sure emacs has a similar feature), then delete everything
>>which is red.


M-x whitespace-mode
M-x old-whitespace-mode


>>
>>Johannes
>>
> I've gotten a bunch of emails recommending that I change the line.
> Attached is the current patch... I will give it an hour or so to see
> if anyone else replies... If not I will commit this as-is.
>
> Thank you!
>
> -- 
> Michael Krufky
>

/* stuff deleted */

> +#define dprintk(args...) { if (debug) printk(KERN_DEBUG "lgdt3302: " args); }

Please:

#define dprintk(args...) do { if (debug) \
	printk(KERN_DEBUG "lgdt3302: " args); } while (0)


(reformat to lines as you wish, just no whitespace after '\')

do { block; } while (0)   is the de-facto way to do that, experience shows
least errors with this approach.


Tomi




More information about the linux-dvb mailing list