[linux-dvb] actual cvs broken?

Philip Prindeville philipp_subx at redfish-solutions.com
Tue Nov 1 01:21:14 CET 2005


Michael Krufky wrote:

> Bernd Lindemann wrote:
>
>> make -C /root/dvb-kernel/build-2.6
>> make[1]: Entering directory `/root/dvb-kernel/build-2.6'
>> [ -L saa7146_video.c ] || ./getlinks
>> make -C /lib/modules/2.6.14-gentoo/source  
>> SUBDIRS=/root/dvb-kernel/build-2.6 AV7110_FIRMWARE= AV7110_OSD=y
>> make[2]: Entering directory `/usr/src/linux-2.6.14-gentoo'
>>  CC [M]  /root/dvb-kernel/build-2.6/cinergyT2.o
>> /root/dvb-kernel/build-2.6/cinergyT2.c: In function `cinergyt2_suspend':
>> /root/dvb-kernel/build-2.6/cinergyT2.c:932: error: invalid operands 
>> to binary >
>> make[3]: *** [/root/dvb-kernel/build-2.6/cinergyT2.o] Error 1
>> make[2]: *** [_module_/root/dvb-kernel/build-2.6] Error 2
>> make[2]: Leaving directory `/usr/src/linux-2.6.14-gentoo'
>> make[1]: *** [all] Error 2
>> make[1]: Leaving directory `/root/dvb-kernel/build-2.6'
>> make: *** [all] Error 2
>
>
> I have fixed the issue... As of now, dvb-kernel cvs is *only* 
> compatable with linux kernel 2.6.14:
>
> This is the patch I applied, which makes the difference between 2.6.13 
> --> 2.6.14 compatability:
>
> [PATCH] swsusp: switch pm_message_t to struct
>
> This adds type-checking to pm_message_t, so that people can't confuse it
> with int or u32.  It also allows us to fix "disk yoyo" during suspend
> (disk spinning down/up/down).
>
> [We've tried that before; since that cpufreq problems were fixed and
> I've tried make allyes config and fixed resulting damage.]
>
> Signed-off-by: Pavel Machek <pavel at suse.cz>
> Signed-off-by: Alexander Nyberg <alexn at telia.com>
> Signed-off-by: Andrew Morton <akpm at osdl.org>
> Signed-off-by: Linus Torvalds <torvalds at osdl.org>
> Signed-off-by: Michael Krufky <mkrufky at m1k.net>
>
> --- drivers/media/dvb/cinergyT2/cinergyT2.c
> +++ drivers/media/dvb/cinergyT2/cinergyT2.c
> @@ -888,7 +888,7 @@ static int cinergyt2_suspend (struct usb
>      if (down_interruptible(&cinergyt2->sem))
>          return -ERESTARTSYS;
>
> -    if (state > 0) {    /* state 0 seems to mean DEVICE_PM_ON */
> +    if (state.event > PM_EVENT_ON) {
>          struct cinergyt2 *cinergyt2 = usb_get_intfdata (intf);
>  #ifdef ENABLE_RC
>          cancel_delayed_work(&cinergyt2->rc_query_work);
>
>
> It is now in cvs.
>
> Cheers,
>
> Michael Krufky
>


Without wishing to polemic...  am I the only person that wishes that
DVB development wasn't tied to having a bleeding-edge kernel?

Given that the kernel *is* modular, why shouldn't the latest
module sources for DVB build against a 2.6.12 kernel?

Is that not a reasonable expectation?

Seems we'd have a broader base of testers to pool with...

-Philip




More information about the linux-dvb mailing list