[linux-dvb] [PATCH] Fix Makefile for NXT200X

Mike Krufky mkrufky at linuxtv.org
Thu Nov 3 15:46:13 CET 2005


Kirk Lapray wrote:

> This patch fixes the Makefile for the NXT200X driver.  There was a 
> small typo.
>
> *Makefile:
> - Change CONFIG_DVB_NXT2002 to CONFIG_DVB_NXT200X for the nxt200x
>
> Signed-off-by: Kirk Lapray <kirk.lapray at gmail.com 
> <mailto:kirk.lapray at gmail.com>>
>
OOPS!  My mistake... Sorry about that...  I'll apply this now and add it 
to my next patchset going to akpm.

Kirk, Andrew had some other comments about nxt200x... Most of them are 
trivial, although this might be something to look at:

Andrew Morton wrote:

>...
>> +static int nxt200x_writebytes (struct nxt200x_state* state, u8 reg, u8 *buf, u8 len)
>> +{
>> +	u8 buf2 [len+1];
>  
>
>
>hm, a variable-sized array, with the size defined by the caller.   I guess as the size is
>in a u8 it's unlikely to cause too much trouble.
>
>(Wonders what the compiler will do if len==255.  256, I think.)
>


For those wondering why I'm doing the upstream patching this time 
around, it's because Johannes got called away on business and asked me 
to temporarily step in.

-- 
Michael Krufky





More information about the linux-dvb mailing list