[linux-dvb] [Patch] Added Nova-S-Plus and Nova-SE2 DVB-S support

Johannes Stezenbach js at linuxtv.org
Tue Nov 29 02:45:20 CET 2005


Hi Steve,

On Sun, Nov 20, 2005, Johannes Stezenbach wrote:
> On Tue, Nov 15, 2005 Steve Toth wrote:
> > 
> > [Patch] Added Nova-S-Plus and Nova-SE2 DVB-S support
> > [Patch] Code cleanup and removed most of the debug related stuff
> > 
> > Signed-off-by: Steven Toth <stoth at hauppauge.com>
> 
> I just committed your patch, and did a few cleanups, which I didn't
> notice earlier:
> 
> - move cx24123_AGC_vals and cx24123_bandselect_vals into .c file
>   and make them static
> - cx24123_get_fec() was a bit confused
> - a bit whitespace here and there
> 
> There's some dubious timeout code in cx24123_pll_writereg(), I guess
> this should go. Is this copied from the Windoze driver?

I didn't receive an answer to this. Do you care to comment?
Can we just drop the timeout cruft?

Johannes



More information about the linux-dvb mailing list