[linux-dvb] Kernel locking in dst [Corrected PATCH]

Henrik Sjoberg henke at epact.se
Tue Oct 18 19:46:14 CEST 2005


There is still some up/down missing around dst_write_tuna (which was
actually the root of my problem).
The following additional patch is a remedy for my problem.

Regards,
Henrik

> Ralph Metzler wrote:
>
>>Manu Abraham writes:
>> > diff -Naurp bt8xx.orig/dst.c bt8xx/dst.c
>> > --- bt8xx.orig/dst.c	2005-09-21 20:29:09.000000000 +0400
>> > +++ bt8xx/dst.c	2005-10-18 19:38:27.000000000 +0400
>> > @@ -910,6 +910,7 @@ static int dst_get_device_id(struct dst_
>> >
>> >  static int dst_probe(struct dst_state *state)
>> >  {
>> > +	sema_init(&state->dst_mutex, 1);
>> >  	if ((rdc_8820_reset(state)) < 0) {
>> >  		dprintk(verbose, DST_ERROR, 1, "RDC 8820 RESET Failed.");
>> >  		return -1;
>> > @@ -960,21 +961,23 @@ static int dst_probe(struct dst_state *s
>> >  int dst_command(struct dst_state *state, u8 *data, u8 len)
>> >  {
>> >  	u8 reply;
>> > +
>> > +	up(&state->dst_mutex);
>> >  	if ((dst_comm_init(state)) < 0) {
>> >  		dprintk(verbose, DST_NOTICE, 1, "DST Communication Initialization
>> Failed.");
>>
>>
>>This should be down()?
>>
>>
>>
> Hello Ralph and all,
>
> I have attached the corrected patch. If it looks okay i can commit it to
> CVS, such that Johannes can make the patchset at the earliest, when he
> is back.
>
>
> Regards,
> Manu
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tuna.patch
Type: text/x-patch
Size: 2085 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20051018/0e5617cc/tuna.bin


More information about the linux-dvb mailing list