[linux-dvb] FusionHDTV5 Gold: full support merged into -mm

Mike Krufky mkrufky at linuxtv.org
Thu Sep 8 23:31:40 CEST 2005


For all those DViCO FusionHDTV5 Gold testers out there, full analog & 
digital support (v4l + dvb) has been merged into 2.6.13-mm2 ... If you'd 
like to test this implementation, please feel free, and let me know if 
anything acts strangely for you.  All you need is kernel sources for 
this, no need to install new stuff from CVS, unless you are experiencing 
the noise bug, outlined below.

Please note:

There is one more FusionHDTV5 Gold related patch still in video4linux 
cvs that has not yet been sent upstream.  I have attached this patch to 
this email.  Here is a short description of the changes that I made 
here, and the reason why:

[BUG]  upon frontend initialization when module is first loaded, there 
is an extremely annoying noise produced by the analog tuner.
This noise goes away once the analog tuner is used to change to a 
channel, -OR- once the digital tuner is used to scan / zap (thanks to 
Mac Michaels)

Here's what I changed in the patch below:

In hunk #1, I removed the check for tda9887.  This is unnecessary 
because TUNER_SET_STANDBY is now part of the v4l tuner API, and it is 
safe to be called, regardless of what tuner is actually present.  This 
makes no change in behavior.

Hunk #2 contains the bug fix... I added an additional call to 
TUNER_SET_STANDBY, immediately after frontend initialization.  Doing 
this has completely fixed the noise problem that I have experienced.

This TUNER_SET_STANDBY call has also been added to cx88 dev init, but as 
the frontend is initialized after cx88 init, the tuner comes out of 
standby, just in time to pierce my eardrums.  SO, the cx88 device init 
standby call doesn't help in the case of FusionHDTV5 Gold.

When I first tested FusionHDTV5 a while back, I didnt have this problem 
at all.... Since then, I've installed alsa-utils, and added the mixer 
restore functionality to my default runlevel.... Ever since then, now 
that the mixer resets the volume at startup, I get this noise...  It 
seems that I am the only one to experience this noise, none of the other 
FusionHDTV5 Gold testers have complained about this yet...  I wonder 
why... Anyway, it's fixed now.

Please, dont complain to us about the noise bug in -mm without trying 
the attached patch.  If, however, you still get some noise after 
applying it, that is the sort of thing that I'd like to hear about.

This patch applies against 2.6.13-mm2 , and it is already present in 
video4linux cvs.  Comments are welcome.

-- 
Signed-off-by: Michael Krufky <mkrufky at linuxtv.org>


-------------- next part --------------
 linux/drivers/media/video/cx88/cx88-dvb.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff -u /tmp/dst.24271 linux/drivers/media/video/cx88/cx88-dvb.c
--- /tmp/dst.24271	2005-09-08 10:48:22.769337625 -0500
+++ linux/drivers/media/video/cx88/cx88-dvb.c	2005-09-08 10:48:22.769337625 -0500
@@ -221,9 +221,7 @@ static int lgdt330x_pll_set(struct dvb_f
 	int err;
 
 	/* Put the analog decoder in standby to keep it quiet */
-	if (core->tda9887_conf) {
-		cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
-	}
+	cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
 
 	dvb_pll_configure(core->pll_desc, buf, params->frequency, 0);
 	dprintk(1, "%s: tuner at 0x%02x bytes: 0x%02x 0x%02x 0x%02x 0x%02x\n",
@@ -402,6 +400,9 @@ static int dvb_register(struct cx8802_de
 		dev->dvb.frontend->ops->info.frequency_max = dev->core->pll_desc->max;
 	}
 
+	/* Put the analog decoder in standby to keep it quiet */
+	cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
+
 	/* register everything */
 	return videobuf_dvb_register(&dev->dvb, THIS_MODULE, dev);
 }


More information about the linux-dvb mailing list