[linux-dvb] read-only module parameters (was: WinTV Nova-T tuning issue)

[Johannes Stezenbach]

On Tue, Sep 13, 2005 at 08:53:34PM +0200, Edgar Toernig wrote:
> > Unload all DVB modules and then try:
> > 
> > modprobe dvb-core dvb_shutdown_timeout=0
> 
> Btw, is there any reason why these variables are exported
> read-only to sysfs?  Any objection against making them rw?
> Changing the timeout becomes a simple:
> 
> echo 0 >/sys/module/dvb_core/parameters/dvb_shutdown_timeout

Yeah, makes sense. Can you add your Signed-off-by: so I can
commit the patch?

Thanks,
Johannes

> --- linux-2.6.13/drivers/media-orig/dvb/dvb-core/dvb_frontend.c 2005-08-29 19:21:12 +0200
> +++ linux-2.6.13/drivers/media/dvb/dvb-core/dvb_frontend.c      2005-09-09 03:41:01 +0200
> @@ -52,13 +52,13 @@ static int dvb_powerdown_on_sleep = 1;
>  
>  module_param_named(frontend_debug, dvb_frontend_debug, int, 0644);
>  MODULE_PARM_DESC(frontend_debug, "Turn on/off frontend core debugging (default:off).");
> -module_param(dvb_shutdown_timeout, int, 0444);
> +module_param(dvb_shutdown_timeout, int, 0644);
>  MODULE_PARM_DESC(dvb_shutdown_timeout, "wait <shutdown_timeout> seconds after close() before suspending hardware");
> -module_param(dvb_force_auto_inversion, int, 0444);
> +module_param(dvb_force_auto_inversion, int, 0644);
>  MODULE_PARM_DESC(dvb_force_auto_inversion, "0: normal (default), 1: INVERSION_AUTO forced always");
> -module_param(dvb_override_tune_delay, int, 0444);
> +module_param(dvb_override_tune_delay, int, 0644);
>  MODULE_PARM_DESC(dvb_override_tune_delay, "0: normal (default), >0 => delay in milliseconds to wait for lock after a tune attempt");
> -module_param(dvb_powerdown_on_sleep, int, 0444);
> +module_param(dvb_powerdown_on_sleep, int, 0644);
>  MODULE_PARM_DESC(dvb_powerdown_on_sleep, "0: do not power down, 1: turn LNB volatage off on sleep (default)");
>  
>  #define dprintk if (dvb_frontend_debug) printk
> 
> 
> _______________________________________________
> linux-dvb mailing list
> linux-dvb at linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>