[linux-dvb] [PATCH] Moving ALPS BSRV2 tuner handling code to separate file.

Andreas Oberritter obi at linuxtv.org
Sat Apr 15 02:42:20 CEST 2006


Michael Krufky wrote:
> Perceval Anichini wrote:
>> Hello all !
>>
>> Continueing to move the frontends code from ttpci/ tp
>> frontends.
>>
>> This patch :   - Moves the ALPS BSRV2 tuner code to frontends/bsrv2.h
>>   - Adapts accordingly ves1x93.{c,h} so that the pll_set ()
>>     function accepts the i2c_adapter as an argument. (Copying
>>     stv0299 behavior...)
>>   - Modify accordingly av7110.c, budget-patch.c, budget.c
>>
>> Could someone please try this patch ? It compiles properly,
>> but I don't have any way to test it, as I don't have a card
>> like that...
> Perceval-
> 
> I think that this was a good idea, although the same exact thing could
> be done for all of the other drivers, potentially leading to the
> creation of many many more modules just for handling pll's ...

It's not just about PLLs, different frontend modules can require
different register settings for symbol rate and other stuff even if they
use the same demod chip.

I like this patch and I think it should be applied. It is a disadvantage
to have all the code and arrays duplicated in several drivers if we
could have it at a single place.

> I would much rather see the pll definition moved into dvb-pll, and the
> pll_set function altered to use dvb_pll_configure.

The code can still be changed to use dvb-pll afterwards without
unnecessary code duplication.

Regards,
Andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060415/d7c12e91/signature.pgp


More information about the linux-dvb mailing list