[linux-dvb] Increase debug level of debug messages in cx88-mpeg

christophpfister at bluemail.ch christophpfister at bluemail.ch
Tue Apr 18 21:48:48 CEST 2006


>Set at least debug level 1 for all debug messages in cx88-mpeg.c to be
>able to turn them off by setting debug=0. Currently I'm getting
>about 10k messages per day from this in my syslog without any
>functional harm.
>
>Please consider applying. Patch is against Linus git tree from 14.4.
>Thanks.
>
>Signed-off-by: Jan Dittmer <jdittmer at ppp0.net>
>
>--- linux-2.6/drivers/media/video/cx88/cx88-mpeg.c~	2006-04-14 16:09:41.000000000
>+0200
>+++ linux-2.6/drivers/media/video/cx88/cx88-mpeg.c	2006-04-14 16:11:19.000000000
>+0200
>@@ -54,7 +54,7 @@ static int cx8802_start_dma(struct cx880
> {
> 	struct cx88_core *core = dev->core;
>
>-	dprintk(0, "cx8802_start_dma %d\n", buf->vb.width);
>+	dprintk(1, "cx8802_start_dma %d\n", buf->vb.width);
>
> 	/* setup fifo + format */
> 	cx88_sram_channel_setup(core, &cx88_sram_channels[SRAM_CH28],
>@@ -104,7 +104,7 @@ static int cx8802_start_dma(struct cx880
> 	q->count = 1;
>
> 	/* enable irqs */
>-	dprintk( 0, "setting the interrupt mask\n" );
>+	dprintk( 1, "setting the interrupt mask\n" );
> 	cx_set(MO_PCI_INTMSK, core->pci_irqmask | 0x04);
> 	cx_set(MO_TS_INTMSK,  0x1f0011);
>
>@@ -117,7 +117,7 @@ static int cx8802_start_dma(struct cx880
> static int cx8802_stop_dma(struct cx8802_dev *dev)
> {
> 	struct cx88_core *core = dev->core;
>-	dprintk( 0, "cx8802_stop_dma\n" );
>+	dprintk( 1, "cx8802_stop_dma\n" );
>
> 	/* stop dma */
> 	cx_clear(MO_TS_DMACNTRL, 0x11);
>@@ -137,10 +137,10 @@ static int cx8802_restart_queue(struct c
> 	struct cx88_buffer *buf;
> 	struct list_head *item;
>
>-	dprintk( 0, "cx8802_restart_queue\n" );
>+	dprintk( 2, "cx8802_restart_queue\n" );
> 	if (list_empty(&q->active))
> 	{
>-		dprintk( 0, "cx8802_restart_queue: queue is empty\n" );
>+		dprintk( 2, "cx8802_restart_queue: queue is empty\n" );
> 		return 0;
> 	}
>
>@@ -198,7 +198,7 @@ void cx8802_buf_queue(struct cx8802_dev
> 	buf->risc.jmp[1] = cpu_to_le32(q->stopper.dma);
>
> 	if (list_empty(&q->active)) {
>-		dprintk( 0, "queue is empty - first active\n" );
>+		dprintk( 1, "queue is empty - first active\n" );
> 		list_add_tail(&buf->vb.queue,&q->active);
> 		cx8802_start_dma(dev, q, buf);
> 		buf->vb.state = STATE_ACTIVE;
>@@ -238,7 +238,7 @@ static void do_cancel_buffers(struct cx8
> 	}
> 	if (restart)
> 	{
>-		dprintk(0, "restarting queue\n" );
>+		dprintk(1, "restarting queue\n" );
> 		cx8802_restart_queue(dev,q);
> 	}
> 	spin_unlock_irqrestore(&dev->slock,flags);
>@@ -258,7 +258,7 @@ static void cx8802_timeout(unsigned long
> {
> 	struct cx8802_dev *dev = (struct cx8802_dev*)data;
>
>-	dprintk(0, "%s\n",__FUNCTION__);
>+	dprintk(1, "%s\n",__FUNCTION__);
>
> 	if (debug)
> 		cx88_sram_channel_dump(dev->core, &cx88_sram_channels[SRAM_CH28]);
>@@ -317,7 +317,7 @@ static void cx8802_mpeg_irq(struct cx880
>
>         /* other general errors */
>         if (status & 0x1f0100) {
>-		dprintk( 0, "general errors: 0x%08x\n", status & 0x1f0100 );
>+		dprintk( 1, "general errors: 0x%08x\n", status & 0x1f0100 );
>                 spin_lock(&dev->slock);
> 		cx8802_stop_dma(dev);
>                 cx8802_restart_queue(dev,&dev->mpegq);
>@@ -350,7 +350,7 @@ static irqreturn_t cx8802_irq(int irq, v
> 			cx8802_mpeg_irq(dev);
> 	};
> 	if (MAX_IRQ_LOOP == loop) {
>-		dprintk( 0, "clearing mask\n" );
>+		dprintk( 1, "clearing mask\n" );
> 		printk(KERN_WARNING "%s/0: irq loop -- clearing mask\n",
> 		       core->name);
> 		cx_write(MO_PCI_INTMSK,0);

I think this issue is already solved (-> see http://linuxtv.org/hg).

Christoph




More information about the linux-dvb mailing list