[linux-dvb] User compile of Hg version broken
Mauro Carvalho Chehab
mchehab at infradead.org
Wed Apr 26 13:58:52 CEST 2006
Em Ter, 2006-04-25 às 16:54 -0700, Trent Piepho escreveu:
> On Tue, 25 Apr 2006, Mauro Carvalho Chehab wrote:
> I didn't need write access to the kernel sources to use make *config before
> this change.
Before this change, the user should go first to kernel dir, do a make
*config, to generate the required files to build menu. While this is not
an issue to advanced users, it is not good to newbies.
> For some reason make thinks it needs to rebuild *conf, when it
> doesn't.
We may include a check for *conf at v4l makefile before calling kernel
make. This will avoid building if it is already there.
>
> I think the command to build *conf isn't correct, as even if I *do* have write
> access, it doesn't work.
>
> It looks like there is a mistake in the Makefile here:
> #################################################
> # Compiler fixup rules
>
> CC += -I$(obj)
>
> This sets CC="cc -I." It seems like -I. belongs with CFLAGS, not CC. Then
> later the build command for making *conf is created:
>
> build := srctree=$(KDIR) HOSTCXX=$(CXX) HOSTCC=$(CC) CONFIG_SHELL=$(CONFIG_SHELL)
> -f $(KDIR)/scripts/Makefile.build obj
>
> The part HOSTCC=$(CC) doesn't work correctly, the make command used becomes:
>
> make blah blah HOSTCC=cc -I. CONFIG_SHELL=sh blah blah
>
> The -I. isn't part of HOSTCC, it's a new -I option to make, telling make
> where to look for included makefiles. That's not what supposed to happen.
> Maybe you want to write HOSTCC="$(CC)", but that's still wrong too. The -I.
> option is for the v4l compile, not for the kernel conf build.
Yes, but it would be safe to have it inside HOSTCC, since . will mean
kernel source dir. Anyway, we may have cleaner ways for doing it.
>
> Fixing this still doesn't let *conf build, there is something else wrong too.
What's happening? Just compiling without needing, or something else is
broken? What kernel version?
Cheers,
Mauro.
More information about the linux-dvb
mailing list