[linux-dvb] [PATCH 1/3] Fix a problem during the access to the IER and ISR registers of the SA7146

Dominik Strasser dominik at die-strassers.de
Mon Dec 25 16:18:59 CET 2006


e9hack schrieb:
> Dominik Strasser wrote:
>   
>> e9hack schrieb:
>>     
> I've looked  to saa7146_i2c_writeout() and to
> wait_event_interruptible_timeout() again. The timeout value is
> calculated after the transfer is started. A high load doesn't shorten
> the real timeout. I think that the old value of 10ms is enough. There is
> no error message from ves1820_writereg(). The values are written
> correctly during the retries. The same timeout messages exist for the
> (old) non interrupt transfer. But in this case the message is only
> printed if I2C-debugging is enabled.. I think you will see this message
> also with the (old) non interrupt transfer, if you change this debug
> message to an always printed message.
>   
OK,
what about the attached patch, to silence the other message (which also 
swamped my logs after I've managed to silence this one) - see my other post.

Signed-off-by: Dominik Strasser <dominik at die-strassers.de>

Regards

Dominik


-------------- next part --------------
diff -r d271c9d20d45 linux/drivers/media/common/saa7146_i2c.c
--- a/linux/drivers/media/common/saa7146_i2c.c	Thu Dec 21 17:07:08 2006 -0200
+++ b/linux/drivers/media/common/saa7146_i2c.c	Mon Dec 25 16:18:05 2006 +0100
@@ -203,7 +203,7 @@ static int saa7146_i2c_writeout(struct s
 				/* a signal arrived */
 				return -ERESTARTSYS;
 
-			printk(KERN_WARNING "saa7146_i2c_writeout: timed out waiting for end of xfer\n");
+			DEB_I2C(("saa7146_i2c_writeout: timed out waiting for end of xfer\n"));
 			return -EIO;
 		}
 		status = saa7146_read(dev, I2C_STATUS);


More information about the linux-dvb mailing list