[linux-dvb] Re: [PATCH] Kworld-ATSC110

[Michael Krufky]

maillist wrote:

> # HG changeset patch
> # User cmeyers at ford.site
> # Node ID c433d5da9fe9095c4fb4861106d82b1c33ec44e3
> # Parent  55f98daf92cfa71671b9bd6b4168a6fe99a8f438
> Verified Kworld-ATSC110
>
> I corrected the composite input and verified the S-video. I also 
> verified the audio mux.

I am applying THIS part to my tree.  I'll assume this means that you've 
tested both svideo AND composite.

>
> Currently I am only able to receive ATSC HD content, not sure why QAM 
> is not working.

What do you mean QAM is not working?  You mean it is untested, right?  
If VSB is working for you, then QAM will work too -- I have similar 
hardware (nxt2004, tuv1236d, saa7135) and have tested this myself.  
Chances are, the QAM testing may have been done using encrypted 
channels, which wouldnt work anyway.

>
> No radio functionality, probably something in the tuv1236D driver.

There IS no driver for TUV1236D -- it is a simple, hybrid 
tuner,supported by tuners.ko (and dvb-pll).  The radio functionality is 
built-in.  Does it just not work?  Do you know for sure that the radio 
feature is available with this card?  Andrew Burri had included this 
with his original patch.... Andrew?

>
> diff -r 55f98daf92cf -r c433d5da9fe9 
> linux/drivers/media/video/saa7134/saa7134-cards.c
> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c    Wed Feb 15 
> 02:19:47 2006 -0500
> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c    Wed Feb 15 
> 02:56:12 2006 -0800
> @@ -2743,29 +2743,22 @@ struct saa7134_board saa7134_boards[] =
>         .radio_type     = UNSET,
>         .tuner_addr     = ADDR_UNSET,
>         .radio_addr     = ADDR_UNSET,
> -        .tda9887_conf   = TDA9887_PRESENT,

WHY do you remove this?  I am 100% sure that tda9887 is present inside 
the "tin can."  do:

"dmesg | grep tda988" while this is enabled and that will prove it to you.

>         .mpeg           = SAA7134_MPEG_DVB,
>         .inputs         = {{
>             .name = name_tv,
>             .vmux = 1,
>             .amux = TV,
>             .tv   = 1,
> -#if 0
> -            /* these inputs are untested */
> -        },{
> -            .name = name_comp1,   /* not yet verified */
> -            .vmux = 4, /* a later patch by
> -                    * Curt Meyers <cmeyers at boilerbots.com>
> -                    * uses .vmux = 3,
> -                    */
> -            .amux = LINE2,
> -        },{
> -            .name = name_svideo,  /* not yet verified */
> -            .vmux = 8,
> -            .amux = LINE2,
> -#endif
> -        }},
> -#if 0
> +        },{
> +            .name = name_comp1,
> +            .vmux = 3,
> +            .amux = LINE2,
> +        },{
> +            .name = name_svideo,
> +            .vmux = 8,
> +            .amux = LINE2,
> +        }},
> +#if 0   // The TUV1236D supports FM radio but don't know how to 
> activate it.
>         .radio = {
>             .name = name_radio,
>             .amux = LINE1,
>
>
Please include a Sign-off on all future patches.  This change that I'm 
about to apply is also present in your previous patch, so I will pull 
your S-O-B that way, but in the future, please include it explicitly.

Thanks,

Mike