[linux-dvb] [PATCH] fix for CX24123 & low symbol rates

Vadim Catana vcatana at registru.md
Wed Feb 15 14:47:25 CET 2006


Johannes Stezenbach wrote:
> Hi Vadim,
> 
> there are a few coding style issues, otherwise the patch looks good:
> 
> 
>>+	u32 FILTUNE;
> 
> 
> please avoid all-uppercase variable names, they look like macros
> 
> 
>>+	/* choose the sampling rate high enough for the required operation,
>>+	   while optimizing the power consumed by the demodulator */
>>+	if(srate < (XTAL*2)/2) {
>>+		pll_mult = 2;
>>+	} else if(srate < (XTAL*3)/2) {
>>+		pll_mult = 3;
>>+	} else if(srate < (XTAL*4)/2) {
>>+		pll_mult = 4;
>>+	} else if(srate < (XTAL*5)/2) {
>>+		pll_mult = 5;
>>+	} else if(srate < (XTAL*6)/2) {
>>+		pll_mult = 6;
>>+	} else if(srate < (XTAL*7)/2) {
>>+		pll_mult = 7;
>>+	} else if(srate < (XTAL*8)/2) {
>>+		pll_mult = 8;
>>+	} else {
>>+		pll_mult = 9;
>>+	};
> 
> 
> please add one space after "if", and no unnecessary { }
> 
> 
> Thanks,
> Johannes
> 

Hi,

attached is the same patch with fixed coding style issues.

Thanks,
Vadim Catana
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4l-dvb.diff
Type: text/x-patch
Size: 13579 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060215/13d85f06/v4l-dvb.bin


More information about the linux-dvb mailing list