[linux-dvb] [PATCH] TT Budget 1500 S

[Perceval Anichini]

> Unfortunately, I'm not sure whether some LNB hardware might be damaged
> if LLC is enabled for the wrong card. That's why I am very careful. ;-)
	I understand that :)

> Hm - sounds like a hardware problem. Apparently the tuner needs a higher
> voltage from the LNBP21 chip...
	Yep! Sounds the same to me !

> The Technotrend/Nexus rev 2.3 cards use the same BSBE1/LNBP21 setup.
> There were no problem reports although it is widely used with vdr.
> Strange.
	If this is a hardware problem of the 1500S, this is normal :)

> My sleep would be better if you could check that. ;-)
> Anyway, if TT recommends that fix it should be safe.
	Ok.
	

> Oops. ;-)
> 
> Please test whether it works if you place something like
> |	if (budget->dev->pci->subsystem_device == 0x1017)
> |		lnbp21_enable_high_lnb_voltage(budget->dvb_frontend, 1)
> after dvb_register_frontend().
	Yes, it is working like a charm. But don't you find
it is a rather bad idea to write a structure like :
	switch (a)
	{
		case 0 :
		[...]
	}

	[...]
	if (a == 0)
		[...]

I do understand that small patches are a good (and necessary !!!) thing
so that it is easier to figure out that what's done is what it shall
be... But in our case, I find this rather breaks the code structure :/
That's why I prefered to handle the problem the way I did in my
patches...

Moreover, the budget.c and budget_ci.c structure is not the same. (And
the same modification in budget_ci is even uglier !!!!), so maybe it
would be a better idea to move first the code handling the card from
budget.c to budget-ci.c, and then modify the LNB stuff ???????

	Am I write when I think that PCI subsystem ID 0x1017 is only
the 1500 S card ????
	Wouldn't it be a good idea to start a README file in the ttpci tree
which sums up the association PCI subsystem ID -> Full card name.
I guess this does exists in the wiki or somewhere, but I didn't find
it (to my great shame !)

> > There is one more thing to do with this TT 1500 S card : move the code
> > handling it in budget-ci -> it indeed has the CI part :)
> 
> Does the card work if you simply move the 'case 0x1017'/'high voltage'
> stuff to budget-ci?
	No, enabling the lnbp21 seems to be mandatory to make the card work
properly... :(

> Iirc there were some CI-related problems.
> But if it works without CI these can be solved later...
	Yep. But as said above, maybe it would be a good thing to fix that
now ???
	The patch only consists of duplicating the lnp21 stuff and the
0x1017 part from budget.c to budget-ci.c.
	I attach a (dirty) patch that does the job (but it needs both of my
patch to be applied first), so that you can have an idea of the job to
be done...

C ya !!!!

(And one more time, thanks for spending time answering/reading me !)

Perceval.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ttpci-1500s-moved-to-budget-ci
Type: text/x-patch
Size: 7254 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060222/826f7474/ttpci-1500s-moved-to-budget-ci.bin