[linux-dvb] [PATCH-REWORKED] frontend.h add dvb-s2 support including backwards compability

Johannes Stezenbach js at linuxtv.org
Fri Feb 24 15:46:09 CET 2006


On Fri, Feb 24, 2006, Klaus Schmidinger wrote:
> Manu Abraham wrote:
> >After a bit of searching around, it seems to me that the following 
> >modulation types needs to be there
> >
> >* BPSK
> >* QPSK
> >* 8PSK
> >* 16APSK
> >* 32APSK
> >
> >of which the last two types seem to be missing.
> >
> >so it could possibly be, IMHO
> >
> >* PSK_B
> >* PSK_Q
> >* PSK_8
> >* PSK_16A
> >* PSK_32A
> 
> Why not go all the way to
> 
> * PSK_2
> * PSK_4
> * PSK_8
> * PSK_16A
> * PSK_32A
> 
> (assuming 'B' stands for Bi-something and 'Q' for Quad-...)
> 
> Just an idea - was wondering why some have letters and others have numbers.

I'd prefer names that match the ones used in the standard
and data sheets. Since 8PSK etc. is not a valid identifier
in C one needs to add a prefix (e.g. MOD_8PSK).
Rename the old ones consistently and provide compat
defines (#define QPSK MOD_QPSK).

(Adding new identifiers is also an incompatible change which
might break apps, but I see no simple way out. One could
do #ifdef _WANT_DVB_S2 the new stuff (like one does for
various glibc features), but that's also ugly.)

Johannes



More information about the linux-dvb mailing list