[linux-dvb] [PATCH] TT Budget 1500 S

Oliver Endriss o.endriss at gmx.de
Fri Feb 24 17:10:49 CET 2006


Perceval Anichini wrote:
> > Because I don't like to have another copy of the LNBP21 code in the
> > tree, I'm working on a patch which moves LNBP21 and BSBE1 stuff to
> > separate files. Doing that requires some other changes as well.
> > I'll post it to the list for discussion asap.
> 	Ok.

Here we go...

Attached you'll find a patch which
- moves LNBP21 stuff to frontends/lnbp21.h (completely rewritten)
- moves tuner code for ALPS BSBE1 to frontends/bsbe1.h
- adapts budget.c accordingly (with high voltage)

Hopefully it works. I don't have a lnbp21 card. ;-)

@all:
Please review. The patch moves duplicated code out of the the card
driver to a single place. I will continue with other card drivers and
tuners later.

@Perceval:
Moving the card to budget-ci.c should be very simple now:
- include "bsbe1.h"
- include "lnbp21.h"
- move card description etc. to budget-ci

> > > Moreover, the budget.c and budget_ci.c structure is not the same. (And
> > > the same modification in budget_ci is even uglier !!!!), so maybe it
> > > would be a better idea to move first the code handling the card from
> > > budget.c to budget-ci.c, and then modify the LNB stuff ???????
> > 
> > Sooner or later, the 3 budget drivers should be merged into one driver.
> > Requires a lot of work: CI/IR/AV code must be factored out, etc.
> 	Errr. Ok. If I can help on this, do not hesitate to ask... I'll
> be glad to contribute...

Great, all improvements are welcome. :)

> Now, what roadmap would you prefer ?
> 
> (1)
> Send a new patch series organized as this :
> 	1/2 -> Move 0x1017 handling to budget-ci
> 	2/2 -> Change the LLC bit (after measuring card output to be
> 	       sure it won't kills the LNB (?))
> 
> Or :
> (2)
> 	1/2 -> LLC bit modification
> 	2/2 -> Move from budget to budget-ci.
> 
> Or :
> (3)
> 	Wait first for LNBP21 modification from you, then (1) or (2)
> 
> (4)
> 	Wait first for the whole ttpci part to be rewriten, and we'll
> see then...
> 
> ??

My patch implements (3)+(2-1/2). Please provide a patch for (2-2/2).

When our patches have been accepted I will checkin the patches into the
Hg repository. Then we can decide what to do next.
Unfortunately my time is very limited. :(

Small steps are preferable:
(1) pull out CI stuff from budget-ci
(2) pull out IR stuff from budget.ci
(3) now budget and budget-ci should look very similar -> merge them.
(The same can be done with budget-av.c later.)

> > > 	Wouldn't it be a good idea to start a README file in the ttpci tree
> > > which sums up the association PCI subsystem ID -> Full card name.
> > > I guess this does exists in the wiki or somewhere, but I didn't find
> > > it (to my great shame !)
> > 
> > http://linuxtv.org/wiki/index.php/Supported_DVB_cards
> > http://linuxtv.org/wiki/index.php/PCI_devices_DVB-S
> > 
> > It would be nice if you could add an entry for this card.
> > Thank you.
> 	Okay, will do it. Just a question : how do i know if a card
> is fullts, or only partial ts ?

You have to check the datasheets.
All saa7146-based budget cards are full-ts.

CU
Oliver

-- 
--------------------------------------------------------
VDR Remote Plugin available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsbe1_lnbp21_refactor_v1.diff
Type: text/x-diff
Size: 13459 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060224/011cc61c/bsbe1_lnbp21_refactor_v1.bin


More information about the linux-dvb mailing list