[linux-dvb] [PATCH] TT Budget 1500 S

Oliver Endriss o.endriss at gmx.de
Sat Feb 25 20:59:12 CET 2006


perceval Anichini wrote:
> [snip]
> 
> > @all:
> > Please review. The patch moves duplicated code out of the the card
> > driver to a single place. I will continue with other card drivers and
> > tuners later.
>     Woah ! Great work :)
>     The patch seems good to me, I just have alittle question :
> 
> In lnbp21_init ()
>     Could this function also sets fe->ops->set_voltage and 
> fe->ops->enable_high_voltage ?
>     IMHO this is a good place to do that :)

Sure. Attached you find a new patch...

> I did not test if the card is effectively working, as I don't have any sat 
> downlink at home.
> I'll make the test monday !

Btw, please verify that module unloading still works. ;-)

> > @Perceval:
> > Moving the card to budget-ci.c should be very simple now:
> > - include "bsbe1.h"
> > - include "lnbp21.h"
> > - move card description etc. to budget-ci
>     Yep, the patch is indeed simple :). I'll send it as soon as I'll be able 
> to make
> a test in real life !
> 
> > > http://linuxtv.org/wiki/index.php/Supported_DVB_cards
> > > http://linuxtv.org/wiki/index.php/PCI_devices_DVB-S
> > >
> > > It would be nice if you could add an entry for this card.
> > > Thank you.
>     Done.

Great.

CU
Oliver

-- 
--------------------------------------------------------
VDR Remote Plugin available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsbe1_lnbp21_refactor_v2.diff
Type: text/x-diff
Size: 13964 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060225/420a8dc1/bsbe1_lnbp21_refactor_v2.bin


More information about the linux-dvb mailing list