[linux-dvb] [PATCH 3/6] DVB-PinnSat: Remove op_sync_orin and irq_err_ignore

Manu Abraham abraham.manu at gmail.com
Mon Jan 9 11:09:16 CET 2006


Edgar Toernig wrote:

>The op_sync_orin and irq_err_ignore code is not really card
>specific.  Some cards set op_sync_orin but any card would
>benefit from setting it.  And irq_err_ignore just shuts up
>some error printks in the irq handler.
>
>This patch activates resyncing for all cards thus making
>op_sync_orin superfluous.
>
>irq_err_ignore is removed.  The error printks are only
>activated then debugging is turned on.
>
>  
>
To make this work you need not move the card specific application of 
these parameters globally to all cards. The reason being that  
individual modules loose the capability of changing this option as all  
cards will be affected in the very same manner.

As i said earlier, i am against this patch.

The same feature can be achieved, without touching all modules .. You 
can see how the very same can be achieved without stirring up so much.


Manu


Signed-off-by: Manu Abraham <manu at linuxtv.org>

# HG changeset patch
# User root at manu.kromtek.com
# Date Sat Dec 24 17:01:34 2005
# Node ID 1b4ffaea140aaff910e5d2b26451c57d2a88caa5
# parent: f515634631e7165ebcc6c995be92661f70587862
Do a RISC_SYNC also



--- a/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c    Sat Dec 24 16:54:12 2005
+++ b/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c    Sat Dec 24 17:01:34 2005
@@ -801,13 +801,13 @@
         card->gpio_mode = 0x0400c060;
         /* should be: 
BT878_A_GAIN=0,BT878_A_PWRDN,BT878_DA_DPM,BT878_DA_SBR,
                   BT878_DA_IOM=1,BT878_DA_APP to enable serial 
highspeed mode. */
-        card->op_sync_orin = 0;
+        card->op_sync_orin = BT878_RISC_SYNC_MASK;
         card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         break;
 
     case BTTV_BOARD_DVICO_DVBT_LITE:
         card->gpio_mode = 0x0400C060;
-        card->op_sync_orin = 0;
+        card->op_sync_orin = BT878_RISC_SYNC_MASK;
         card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         /* 26, 15, 14, 6, 5
          * A_PWRDN  DA_DPM DA_SBR DA_IOM_DA
@@ -823,7 +823,7 @@
     case BTTV_BOARD_NEBULA_DIGITV:
     case BTTV_BOARD_AVDVBT_761:
         card->gpio_mode = (1 << 26) | (1 << 14) | (1 << 5);
-        card->op_sync_orin = 0;
+        card->op_sync_orin = BT878_RISC_SYNC_MASK;
         card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         /* A_PWRDN DA_SBR DA_APP (high speed serial) */
         break;
@@ -855,7 +855,7 @@
 
     case BTTV_BOARD_PC_HDTV:
         card->gpio_mode = 0x0100EC7B;
-        card->op_sync_orin = 0;
+        card->op_sync_orin = BT878_RISC_SYNC_MASK;
         card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         break;
 

# HG changeset patch
# User root at manu.kromtek.com
# Date Sat Dec 24 16:54:12 2005
# Node ID f515634631e7165ebcc6c995be92661f70587862
# parent: 70e9c12d0066a13eb2902f5a5cf0610e92a7457f
Ignore FBUS and FDSR errors



--- a/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c    Wed Dec 21 13:24:21 2005
+++ b/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c    Sat Dec 24 16:54:12 2005
@@ -802,13 +802,13 @@
         /* should be: 
BT878_A_GAIN=0,BT878_A_PWRDN,BT878_DA_DPM,BT878_DA_SBR,
                   BT878_DA_IOM=1,BT878_DA_APP to enable serial 
highspeed mode. */
         card->op_sync_orin = 0;
-        card->irq_err_ignore = 0;
+        card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         break;
 
     case BTTV_BOARD_DVICO_DVBT_LITE:
         card->gpio_mode = 0x0400C060;
         card->op_sync_orin = 0;
-        card->irq_err_ignore = 0;
+        card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         /* 26, 15, 14, 6, 5
          * A_PWRDN  DA_DPM DA_SBR DA_IOM_DA
          * DA_APP(parallel) */
@@ -824,14 +824,14 @@
     case BTTV_BOARD_AVDVBT_761:
         card->gpio_mode = (1 << 26) | (1 << 14) | (1 << 5);
         card->op_sync_orin = 0;
-        card->irq_err_ignore = 0;
+        card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         /* A_PWRDN DA_SBR DA_APP (high speed serial) */
         break;
 
     case BTTV_BOARD_AVDVBT_771: //case 0x07711461:
         card->gpio_mode = 0x0400402B;
         card->op_sync_orin = BT878_RISC_SYNC_MASK;
-        card->irq_err_ignore = 0;
+        card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         /* A_PWRDN DA_SBR  DA_APP[0] PKTP=10 RISC_ENABLE FIFO_ENABLE*/
         break;
 
@@ -856,7 +856,7 @@
     case BTTV_BOARD_PC_HDTV:
         card->gpio_mode = 0x0100EC7B;
         card->op_sync_orin = 0;
-        card->irq_err_ignore = 0;
+        card->irq_err_ignore = BT878_AFBUS | BT878_AFDSR;
         break;
 
     default:



More information about the linux-dvb mailing list