[linux-dvb] [PATCH 3/6] DVB-PinnSat: Remove op_sync_orin and irq_err_ignore

Edgar Toernig froese at gmx.de
Mon Jan 9 17:54:35 CET 2006


Manu Abraham wrote:
>
> To make this work you need not move the card specific application of 
> these parameters globally to all cards. The reason being that  
> individual modules loose the capability of changing this option as all  
> cards will be affected in the very same manner.

And this is right so!  As I said, these options are _not_ card
specific.  The frontend and how it is connected to the bt878 is
totally irrelevant.  The card specific drivers shouldn't deal
with this - it's the responsibility of the dma and irq routines
in bt878.c to get this right.  Afaics, all this cruft has been
added over the years - i.e. someone observed that resyncing was
necessary and with the (unfounded) fear of breaking something
he added code to enable it only for his card.  Time to clean up
all this cruft.

> The same feature can be achieved, without touching all modules ..

I don't touch _all modules_:

 bt878.c     |   30 +++++++++-------------------
 bt878.h     |    5 ----
 dvb-bt8xx.c |   55 ++++++----------------------------------------------
 dvb-bt8xx.h |    2 -
 4 files changed, 18 insertions(+), 74 deletions(-)

The resulting codes is much cleaner than before and gives the same
behaviour as your 'minimal size patch'.

> You can see how the very same can be achieved without stirring up so much.

But sometimes it's better to clean up and remove old and crufty stuff.
That code has accumulated a lot of dust in the years ...

Ciao, ET.



More information about the linux-dvb mailing list