[linux-dvb] [PATCH 3/6] DVB-PinnSat: Remove op_sync_orin and irq_err_ignore

Michael Krufky mkrufky at gmail.com
Mon Jan 9 18:17:42 CET 2006


On 1/9/06, Edgar Toernig <froese at gmx.de> wrote:
> Manu Abraham wrote:
> >
> > To make this work you need not move the card specific application of
> > these parameters globally to all cards. The reason being that
> > individual modules loose the capability of changing this option as all
> > cards will be affected in the very same manner.
>
> And this is right so!  As I said, these options are _not_ card
> specific.  The frontend and how it is connected to the bt878 is
> totally irrelevant.  The card specific drivers shouldn't deal
> with this - it's the responsibility of the dma and irq routines
> in bt878.c to get this right.  Afaics, all this cruft has been
> added over the years - i.e. someone observed that resyncing was
> necessary and with the (unfounded) fear of breaking something
> he added code to enable it only for his card.  Time to clean up
> all this cruft.
>
> > The same feature can be achieved, without touching all modules ..
>
> I don't touch _all modules_:
>
>  bt878.c     |   30 +++++++++-------------------
>  bt878.h     |    5 ----
>  dvb-bt8xx.c |   55 ++++++----------------------------------------------
>  dvb-bt8xx.h |    2 -
>  4 files changed, 18 insertions(+), 74 deletions(-)
>
> The resulting codes is much cleaner than before and gives the same
> behaviour as your 'minimal size patch'.
>
> > You can see how the very same can be achieved without stirring up so much.
>
> But sometimes it's better to clean up and remove old and crufty stuff.
> That code has accumulated a lot of dust in the years ...
>
> Ciao, ET.

Just my opinion ... I agree with Edgar on this, although I trust
Manu's Judgement, as he has delved deeper into the dvb-bt8xx stuff
than I have. ...

However, Edgar, it looks to me like you have neglected to include your
Sign-off on ANY of your patches in this patchset.

Nobody is going to apply any of these into cvs without a proper sign-off...

Please send your future patches to the list WITH a proper sign-off, in the form:

Signed-off-by: Your Name <email at addre.ss>

...You might want to check README.CVS ... or SubmittingPatches in the
kernel source, or whatnot...

 *I* wont be applying any of these, I will leave it to the pros...
(Manu, Johannes, et al)  but you may want to re-send them with a
sign-off if you want any chance of inclusion.

Edgar, thanks for your hard work... Hopefully it can be used for some
good.  I know the sign-off thing seems trivial, but it is a policy
that we all adhere to.

Cheers,

Michael



More information about the linux-dvb mailing list